Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: rename CryptoPemCallback -> PasswordCallback #12787

Closed
wants to merge 2 commits into from

Conversation

@danbev
Copy link
Member

commented May 2, 2017

While reading through node_crypto.cc I think the code could perhaps
be be a made a little clearer if CryptPemCallback was renamed.

I admit that I'm very new to the code base and openssl but having a
name like PasswordCallback or something similar would have helped me
so I'm suggesting this change.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

src: rename CryptoPemCallback -> PasswordCallback
While reading through node_crypto.cc I think the code could perhaps
be be a made a little clearer if CryptPemCallback was renamed.

I admit that I'm very new to the code base and openssl but having a
name like PasswordCallback or something similar would have helped me
so I'm suggesting this change.
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 2, 2017

@addaleax
Copy link
Member

left a comment

LGTM, it doesn’t look like there’s much that could go wrong here 😄

The callback is for making a passphrase available to OpenSSL when it discovers that it needs one, right? Maybe add a quick comment above it for that?

@danbev

This comment has been minimized.

Copy link
Member Author

commented May 2, 2017

The callback is for making a passphrase available to OpenSSL when it discovers that it needs one, right? Maybe add a quick comment above it for that?

No problems, I'll add a comment about that.

@cjihrig
cjihrig approved these changes May 2, 2017
@jasnell
jasnell approved these changes May 2, 2017
danbev added a commit to danbev/node that referenced this pull request May 4, 2017
src: rename CryptoPemCallback -> PasswordCallback
While reading through node_crypto.cc I think the code could perhaps
be be a made a little clearer if CryptPemCallback was renamed.

I admit that I'm very new to the code base and openssl but having a
name like PasswordCallback or something similar would have helped me
so I'm suggesting this change.

PR-URL: nodejs#12787
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 4, 2017

Landed in ebcd8c6

@danbev danbev closed this May 4, 2017

@danbev danbev deleted the danbev:crypto-password-callback branch May 4, 2017

@sam-github

This comment has been minimized.

Copy link
Member

commented May 5, 2017

Late here, but +1

anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
src: rename CryptoPemCallback -> PasswordCallback
While reading through node_crypto.cc I think the code could perhaps
be be a made a little clearer if CryptPemCallback was renamed.

I admit that I'm very new to the code base and openssl but having a
name like PasswordCallback or something similar would have helped me
so I'm suggesting this change.

PR-URL: nodejs#12787
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 18, 2017
src: rename CryptoPemCallback -> PasswordCallback
While reading through node_crypto.cc I think the code could perhaps
be be a made a little clearer if CryptPemCallback was renamed.

I admit that I'm very new to the code base and openssl but having a
name like PasswordCallback or something similar would have helped me
so I'm suggesting this change.

PR-URL: #12787
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn added a commit that referenced this pull request Jun 20, 2017
src: rename CryptoPemCallback -> PasswordCallback
While reading through node_crypto.cc I think the code could perhaps
be be a made a little clearer if CryptPemCallback was renamed.

I admit that I'm very new to the code base and openssl but having a
name like PasswordCallback or something similar would have helped me
so I'm suggesting this change.

PR-URL: #12787
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
src: rename CryptoPemCallback -> PasswordCallback
While reading through node_crypto.cc I think the code could perhaps
be be a made a little clearer if CryptPemCallback was renamed.

I admit that I'm very new to the code base and openssl but having a
name like PasswordCallback or something similar would have helped me
so I'm suggesting this change.

PR-URL: #12787
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.