Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add callback to fs.close() in test-fs-chmod #12795

Closed
wants to merge 1 commit into from

Conversation

@vsemozhetbyt
Copy link
Contributor

commented May 2, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, fs

To avoid [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2017

@cjihrig
cjihrig approved these changes May 2, 2017
@lpinca
lpinca approved these changes May 2, 2017
@Trott

This comment has been minimized.

Copy link
Member

commented May 2, 2017

Maybe instead of common.noop, use assert.ifError? (I'm OK if you don't. Just an idea.)

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2017

@Trott This makes sense) Is assert.ifError static? Can I just fs.close(fd, assert.ifError);?

@jasnell

This comment has been minimized.

Copy link
Member

commented May 2, 2017

@vsemozhetbyt ... yes, in this particular case assert.ifError should work just fine.

test: add callback to fs.close() in test-fs-chmod
To avoid '[DEP0013] DeprecationWarning:
Calling an asynchronous function without callback is deprecated.'

@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:test-fs-chmod-cb branch to b157436 May 2, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2017

@Trott
Trott approved these changes May 2, 2017
Copy link
Member

left a comment

LGTM if CI is green

@refack
refack approved these changes May 4, 2017
@jasnell
jasnell approved these changes May 4, 2017
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2017

Landed in 712596f

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:test-fs-chmod-cb branch May 4, 2017

vsemozhetbyt added a commit that referenced this pull request May 4, 2017
test: add callback to fs.close() in test-fs-chmod
To avoid '[DEP0013] DeprecationWarning:
Calling an asynchronous function without callback is deprecated.'

PR-URL: #12795
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
test: add callback to fs.close() in test-fs-chmod
To avoid '[DEP0013] DeprecationWarning:
Calling an asynchronous function without callback is deprecated.'

PR-URL: nodejs#12795
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 18, 2017
test: add callback to fs.close() in test-fs-chmod
To avoid '[DEP0013] DeprecationWarning:
Calling an asynchronous function without callback is deprecated.'

PR-URL: #12795
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn added a commit that referenced this pull request Jun 20, 2017
test: add callback to fs.close() in test-fs-chmod
To avoid '[DEP0013] DeprecationWarning:
Calling an asynchronous function without callback is deprecated.'

PR-URL: #12795
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
test: add callback to fs.close() in test-fs-chmod
To avoid '[DEP0013] DeprecationWarning:
Calling an asynchronous function without callback is deprecated.'

PR-URL: #12795
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.