Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: updated readFileSync in fs.md #12800

Closed
wants to merge 2 commits into from

Conversation

@thelostone-mc
Copy link
Contributor

commented May 2, 2017

Refs: #10962

Updated fs.md stating fs.readFileAsync is platform specific

Documents Updated:

  • doc/api/fs.md
Checklist
Affected core subsystem(s)

doc

@fhalde

This comment has been minimized.

Copy link
Contributor

commented May 2, 2017

prefix the PR and commit with the subsystem you changed. In this case doc
https://github.com/nodejs/node/blob/master/CONTRIBUTING.md

doc/api/fs.md Outdated
@@ -1549,6 +1549,23 @@ Synchronous version of [`fs.readFile`][]. Returns the contents of the `file`.
If the `encoding` option is specified then this function returns a
string. Otherwise it returns a buffer.

_Note: The behavior of `fs.readFileSync()` is platform specific. As such,
reading a directory on macOS and Linux and Windows - see example

This comment has been minimized.

Copy link
@refack

refack May 2, 2017

Member

macOS, Linux, and Windows
We use the Oxford comma

This comment has been minimized.

Copy link
@refack

refack May 2, 2017

Member

move "see example below" to the last line of the paragraph

doc/api/fs.md Outdated
@@ -1549,6 +1549,23 @@ Synchronous version of [`fs.readFile`][]. Returns the contents of the `file`.
If the `encoding` option is specified then this function returns a
string. Otherwise it returns a buffer.

_Note: The behavior of `fs.readFileSync()` is platform specific. As such,
reading a directory on macOS and Linux and Windows - see example
below - will return an error. In contrast, on FreeBSD, contents of

This comment has been minimized.

Copy link
@refack

refack May 2, 2017

Member
  • remove "In contrast"
  • add the - "on FreeBSD, the content"
doc/api/fs.md Outdated
_Note: The behavior of `fs.readFileSync()` is platform specific. As such,
reading a directory on macOS and Linux and Windows - see example
below - will return an error. In contrast, on FreeBSD, contents of
the file will be returned._

This comment has been minimized.

Copy link
@refack

refack May 2, 2017

Member

You should explain which file? as it's a directory?

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc May 2, 2017

Author Contributor

@refack Would that mean :
On FreeBSD, the contents of the files in the directory will be returned.

This comment has been minimized.

Copy link
@refack

refack May 2, 2017

Member

If that is what happens, then yes, exactly.
BTW: that's strange, how do you know when one file ends and another begins... 🤔

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc May 2, 2017

Author Contributor

I'm tempted to set up FreeBSD and check it out now 😛

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented May 2, 2017

@refack

This comment has been minimized.

Copy link
Member

commented May 2, 2017

Thank you very much for the contribution 🥇
(don't take the comments too hard 😉)

@thelostone-mc

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2017

@refack Haha!! Well next time you won't be able to point things like this out in my next PR 😎
Thanks !!

@refack

This comment has been minimized.

Copy link
Member

commented May 2, 2017

@refack Haha!! Well next time you won't be able to point things like this out in my next PR 😎
Thanks !!

I agree, the best way to learn is by doing!

@thelostone-mc thelostone-mc force-pushed the thelostone-mc:docs branch May 2, 2017

@thelostone-mc thelostone-mc changed the title Updated fs.md for readFileSync doc: updated readFileSync in fs.md May 2, 2017

@thelostone-mc thelostone-mc force-pushed the thelostone-mc:docs branch May 2, 2017

@thelostone-mc

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2017

@fhalde Thanks !! 🕺

doc/api/fs.md Outdated
@@ -1549,6 +1549,23 @@ Synchronous version of [`fs.readFile`][]. Returns the contents of the `file`.
If the `encoding` option is specified then this function returns a
string. Otherwise it returns a buffer.

_Note: The behavior of `fs.readFileSync()` is platform specific. As such,
reading a directory on macOS, Linux and Windows will return an error.
On FreeBSD, the contents of the files in directory will be returned.

This comment has been minimized.

Copy link
@mscdex

mscdex May 2, 2017

Contributor

What does this mean exactly? Is it just all of the files concatenated together one after the other? With or without boundaries?

This comment has been minimized.

Copy link
@jasnell

jasnell May 2, 2017

Member

I've been working (slowly) on getting as much consistency as possible in the Note sections in the docs... Can you please make this...

*Note*: The behavior...

... and do not bold the entire paragraph.

doc/api/fs.md Outdated

```js
// macOS, Linux and Windows
fs.readFileSync('<directory>', (err, data) => {

This comment has been minimized.

Copy link
@mscdex

mscdex May 2, 2017

Contributor

Synchronous methods don't accept callbacks.

doc/api/fs.md Outdated
@@ -1549,6 +1549,23 @@ Synchronous version of [`fs.readFile`][]. Returns the contents of the `file`.
If the `encoding` option is specified then this function returns a
string. Otherwise it returns a buffer.

_Note: The behavior of `fs.readFileSync()` is platform specific. As such,

This comment has been minimized.

Copy link
@mscdex

mscdex May 2, 2017

Contributor

I think we should be more general about what functions are affected since it would also include the async counterpart as well as anyone using fs.open('/path/to/dir') with fs.read() or their sync counterparts for example.

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc May 3, 2017

Author Contributor

Won't the example clear this up? I agree your comment give room for less confusion
But the line below would clear up that confusion:

When the given path identifies a directory, the behavior of fs.readFile() and fs.readFileSync() is platform specific

This comment has been minimized.

Copy link
@mscdex

mscdex May 3, 2017

Contributor

Except those methods both implicitly use fs.open()/fs.read(). So really the note should be above one of those instead, but many people use readFile() as well. That is why I suggested possibly putting the note for both readFile() and fs.read() (and their sync counterparts).

doc/api/fs.md Outdated
@@ -1549,6 +1549,23 @@ Synchronous version of [`fs.readFile`][]. Returns the contents of the `file`.
If the `encoding` option is specified then this function returns a
string. Otherwise it returns a buffer.

_Note: The behavior of `fs.readFileSync()` is platform specific. As such,
reading a directory on macOS, Linux and Windows will return an error.
On FreeBSD, the contents of the files in directory will be returned.

This comment has been minimized.

Copy link
@jasnell

jasnell May 2, 2017

Member

I've been working (slowly) on getting as much consistency as possible in the Note sections in the docs... Can you please make this...

*Note*: The behavior...

... and do not bold the entire paragraph.

doc/api/fs.md Outdated
@@ -1549,6 +1549,23 @@ Synchronous version of [`fs.readFile`][]. Returns the contents of the `file`.
If the `encoding` option is specified then this function returns a
string. Otherwise it returns a buffer.

_Note: The behavior of `fs.readFileSync()` is platform specific. As such,

This comment has been minimized.

Copy link
@jasnell

jasnell May 2, 2017

Member

I would make this first line...

When the given path identifies a directory, the behavior of `fs.readFile()` and
`fs.readFileSync()` is platform specific. On macOS, Linux and Windows, an
error will be returned. On FreeBSD...

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc May 2, 2017

Author Contributor

@jasnell If i were to do this, this would be first line fs.readFile().
Would we need the same to be copied even for fs.readFileSync() ?
Also , would I be giving examples for both sync and async counterparts ?

@thelostone-mc thelostone-mc force-pushed the thelostone-mc:docs branch 2 times, most recently May 2, 2017

doc/api/fs.md Outdated
@@ -1377,10 +1377,10 @@ On Linux, positional writes don't work when the file is opened in append mode.
The kernel ignores the position argument and always appends the data to
the end of the file.

_Note: The behavior of `fs.open()` is platform specific for some flags. As such,
*Note*: The behavior of `fs.open()` is platform specific for some flags. As such,

This comment has been minimized.

Copy link
@Trott

Trott May 3, 2017

Member

Nit: platform specific -> platform-specific

This comment has been minimized.

Copy link
@Trott

Trott May 3, 2017

Member

(Although I know you didn't write that text. But while we're here...)

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc May 3, 2017

Author Contributor

Consider it done.

doc/api/fs.md Outdated
@@ -1524,11 +1524,27 @@ If `options` is a string, then it specifies the encoding. Example:
```js
fs.readFile('/etc/passwd', 'utf8', callback);
```
*Note*: When the given path identifies a directory, the behavior of
`fs.readFile()` and `fs.readFileSync()` is platform specific.On macOS, Linux

This comment has been minimized.

Copy link
@Trott

Trott May 3, 2017

Member

Nit: platform specific -> platform-specific

This comment has been minimized.

Copy link
@Trott

Trott May 3, 2017

Member

Please put a space after the period.

This comment has been minimized.

Copy link
@Trott

Trott May 3, 2017

Member

Comma after Linux please.

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc May 3, 2017

Author Contributor

@Trott comma after Linux instead of and. Are you sure about that?

This comment has been minimized.

Copy link
@Trott

Trott May 4, 2017

Member

@adityaanandmc Comma after Linux and keep the and:

On macOs, Linux, and Windows, an error will be returned.

That would be a serial comma and be in accordance with the style guide for Node.js docs.

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc May 4, 2017

Author Contributor

@Trott Haha yeah !! @refack had pointed that out! 😅

doc/api/fs.md Outdated
*Note*: When the given path identifies a directory, the behavior of
`fs.readFile()` and `fs.readFileSync()` is platform specific.On macOS, Linux
and Windows, an error will be returned. On FreeBSD, the contents of the files
in directory will be returned.

This comment has been minimized.

Copy link
@Trott

Trott May 3, 2017

Member

Is this supposed to say in the directory rather than in directory?

doc/api/fs.md Outdated
@@ -1524,11 +1524,27 @@ If `options` is a string, then it specifies the encoding. Example:
```js
fs.readFile('/etc/passwd', 'utf8', callback);
```
*Note*: When the given path identifies a directory, the behavior of

This comment has been minimized.

Copy link
@Trott

Trott May 3, 2017

Member

Would it be too imprecise to say When the path is a directory instead of When the given path identifies a directory? The former seems clearer to me, even if the latter may be more precise.

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc May 3, 2017

Author Contributor

Makes sense. Will change it

@Trott
Copy link
Member

left a comment

I left a bunch of small comments, although most of them probably shouldn't stop this from landing if the contributor is exhausted from requests for small changes. :-D (Also, whoever lands it can probably fix any of them that are important.)

@mscdex

This comment has been minimized.

Copy link
Contributor

commented May 3, 2017

I think a similar note should be made above fs.read()/fs.readSync() for file descriptors for directories.

@refack
refack approved these changes May 3, 2017
@thelostone-mc

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2017

@Trott Looked into the comments and changes everything accordingly except the

Comma after Linux please.

Well, any number of small fixes -> still worth it for documentation, so it's alright!

@thelostone-mc thelostone-mc force-pushed the thelostone-mc:docs branch 2 times, most recently May 3, 2017

doc/api/fs.md Outdated
@@ -1524,11 +1524,27 @@ If `options` is a string, then it specifies the encoding. Example:
```js
fs.readFile('/etc/passwd', 'utf8', callback);
```
*Note*: When the path is a directory, the behavior of
`fs.readFile()` and [`fs.readFileSync()`][] is platform-specific. On macOS, Linux
and Windows, an error will be returned. On FreeBSD, the contents of the files

This comment has been minimized.

Copy link
@refack

refack May 3, 2017

Member

@Trott is not just being picky. It's called the "oxford comma" and we ask for its use in our style guide

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc May 3, 2017

Author Contributor

@refack
Did not see that! Got it. Fixed!
@Trott Sorry about that!! Didn't see the guide

Question: [`fs.readFileSync()`][]
Is this the right way to link this to the title fs.readFileSync() ?
Doesn't seem to be working.

This comment has been minimized.

Copy link
@refack

refack May 3, 2017

Member

Should be... It doesn't work in the GitHub web view but will work in https://nodejs.org/api/fs.html#fs_fs_readfilesync_file_options

@thelostone-mc thelostone-mc force-pushed the thelostone-mc:docs branch May 3, 2017

@refack
refack approved these changes May 3, 2017
@jasnell
jasnell approved these changes May 4, 2017
@cjihrig
cjihrig approved these changes May 4, 2017
@refack
refack approved these changes May 4, 2017
// => [Error: EISDIR: illegal operation on a directory, read <directory>]

// FreeBSD
fs.readFileSync('<directory>'); // => null, <data>

This comment has been minimized.

Copy link
@s0m3on3

s0m3on3 May 4, 2017

maybe just <data> ?

doc/api/fs.md Outdated
*Note*: When the path is a directory, the behavior of
`fs.readFile()` and [`fs.readFileSync()`][] is platform-specific. On macOS,
Linux, and Windows, an error will be returned. On FreeBSD, the contents
of the files in the directory will be returned.

This comment has been minimized.

Copy link
@s0m3on3

s0m3on3 May 4, 2017

$ mkdir test && echo hello > test/1 && echo world > test/2
$ node -p "fs.readFileSync('test')"
<Buffer 03 00 00 00>
$ node -p "fs.readFileSync('/tmp')"
<Buffer 03 00 00 00 00 00 00>

Doesn't look like the contents 😄
FreeBSD 11

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc May 4, 2017

Author Contributor

@s0m3on3 Have look at the options parameter in the doc, you can pass the encoding format as "utf-8" to get the contents in a readable format.

If no encoding is specified, then the raw buffer is returned.

This comment has been minimized.

Copy link
@s0m3on3

s0m3on3 May 4, 2017

This buffer doesn't look like a readable utf8 string too

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc May 4, 2017

Author Contributor

Could you try it with : node -p "fs.readFileSync('test', 'utf-8')"

I'm on MacOS, so I tried it with fs.readFileSync() on a file instead of a directory and it worked as expected!

This comment has been minimized.

Copy link
@s0m3on3

s0m3on3 May 5, 2017

@adityaanandmc No problem

$ node -p "fs.readFileSync('test', 'utf-8')"
�

The same as

Buffer.from([3, 0, 0, 0]).toString("utf-8")

What did you expect ? 😃
Yes, macOS works as expected(throws an error), but the subject is FreeBSD, and "test" is a directory.

On FreeBSD, the contents of the files in the directory will be returned.

This is wrong.
Linux(Darwin too) doesn't allow using the read syscall to read bytes from a directory, but FreeBSD does 😐
And the result doesn't look like the contents of the files in the directory

This comment has been minimized.

Copy link
@refack

refack May 5, 2017

Member

@s0m3on3 so what are those?

$ node -p "fs.readFileSync('test')"
<Buffer 03 00 00 00>
$ node -p "fs.readFileSync('/tmp')"
<Buffer 03 00 00 00 00 00 00>

This comment has been minimized.

Copy link
@s0m3on3

s0m3on3 May 5, 2017

@refack I don't know. The directory contents as a file, some internal structure

This comment has been minimized.

Copy link
@refack

refack May 5, 2017

Member

I suggest:
On FreeBSD, a representation of the directory's contents will be returned.

@refack

This comment has been minimized.

Copy link
Member

commented May 5, 2017

I spun up a freeBSD vm and got this:

> fs.readFileSync('test', {encoding:'utf-8'}).replace('\u0000', ' ')
'�M\u0005 \f\u0000\u0004\u0001.\u0000\u0000\u0000\u0006�\u0004\u0000\f\u0000\u0004\u0002..\u0000\u0000�M\u0005\u0000\u001c\u0000\u0004\u0013this_is_a_directory\u0000D�\u0004\u0000\u0010\u0000\b\u0005hello\u0000��N�\u0004\u0000�\u0001\b\bduck.txt\u0000\u0001v�\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000'
> fs.readFileSync('test', {encoding:'utf-8'}).replace(/\u0000/g, ' ')
'�M\u0005 \f \u0004\u0001.   \u0006�\u0004 \f \u0004\u0002..  �M\u0005 \u001c \u0004\u0013this_is_a_directory D�\u0004 \u0010 \b\u0005hello ��N�\u0004 �\u0001\b\bduck.txt \u0001v�                                                                                                                                                                                                                                                                                                                                                                                                                                        '
> fs.readdirSync('test')
[ 'duck.txt', 'hello', 'this_is_a_directory' ]
>

So IMHO we should say:
On FreeBSD, a representation of the directory's contents will be returned.

doc/api/fs.md Outdated
*Note*: When the path is a directory, the behavior of
`fs.readFile()` and [`fs.readFileSync()`][] is platform-specific. On macOS,
Linux, and Windows, an error will be returned. On FreeBSD, the contents
of the files in the directory will be returned.

This comment has been minimized.

Copy link
@refack

refack May 5, 2017

Member

I suggest:
On FreeBSD, a representation of the directory's contents will be returned.

doc: updated readFileSync in fs.md
Updated fs.md stating fs.readFileAsync is platform specific

Refs: #10962

@thelostone-mc thelostone-mc force-pushed the thelostone-mc:docs branch to bd37c00 May 5, 2017

@thelostone-mc

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2017

@refack Done!!

@refack
refack approved these changes May 5, 2017
refack added a commit that referenced this pull request May 5, 2017
doc: update readFileSync in fs.md
* Updated fs.md stating fs.readFileAsync is platform specific
* Fix formatting of `note`s

PR-URL: #12800
Refs: #10962
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@refack

This comment has been minimized.

Copy link
Member

commented May 5, 2017

Landed in: 2614d24

@refack refack closed this May 5, 2017

@refack

This comment has been minimized.

Copy link
Member

commented May 5, 2017

anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
doc: update readFileSync in fs.md
* Updated fs.md stating fs.readFileAsync is platform specific
* Fix formatting of `note`s

PR-URL: nodejs#12800
Refs: nodejs#10962
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@thelostone-mc thelostone-mc deleted the thelostone-mc:docs branch May 7, 2017

@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 18, 2017
doc: update readFileSync in fs.md
* Updated fs.md stating fs.readFileAsync is platform specific
* Fix formatting of `note`s

PR-URL: #12800
Refs: #10962
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn added a commit that referenced this pull request Jun 20, 2017
doc: update readFileSync in fs.md
* Updated fs.md stating fs.readFileAsync is platform specific
* Fix formatting of `note`s

PR-URL: #12800
Refs: #10962
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
doc: update readFileSync in fs.md
* Updated fs.md stating fs.readFileAsync is platform specific
* Fix formatting of `note`s

PR-URL: #12800
Refs: #10962
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.