Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove unused code from test.py #12806

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented May 3, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@Trott

This comment has been minimized.

Copy link
Member Author

commented May 3, 2017

@refack
refack approved these changes May 3, 2017
Copy link
Member

left a comment

Bless you

@cjihrig
cjihrig approved these changes May 3, 2017
@refack

This comment has been minimized.

Copy link
Member

commented May 3, 2017

Just from interest, how did you get the "unused" set?

@Trott

This comment has been minimized.

Copy link
Member Author

commented May 3, 2017

Just from interest, how did you get the "unused" set?

vulture tools/test.py test/*/testcfg.py

@refack

This comment has been minimized.

Copy link
Member

commented May 4, 2017

vulture tools/test.py test/*/testcfg.py

Ohhhhh when I get the chance I'm gonna do this to GYP. Oh yeah do it so hard 🤣

@jasnell
jasnell approved these changes May 4, 2017
Trott added a commit to Trott/io.js that referenced this pull request May 5, 2017
tools: remove unused code from test.py
PR-URL: nodejs#12806
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 5, 2017

Landed in 53c88fa

@Trott Trott closed this May 5, 2017

anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
tools: remove unused code from test.py
PR-URL: nodejs#12806
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 18, 2017
tools: remove unused code from test.py
PR-URL: #12806
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn added a commit that referenced this pull request Jun 20, 2017
tools: remove unused code from test.py
PR-URL: #12806
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
tools: remove unused code from test.py
PR-URL: #12806
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.