Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: standard-conformant C0 control and whitespace handling #12846

Closed
wants to merge 1 commit into from

Conversation

@TimothyGu
Copy link
Member

commented May 5, 2017

Fixes: #12825
Refs: web-platform-tests/wpt#5792

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url

@jasnell
jasnell approved these changes May 5, 2017
Copy link
Member

left a comment

Code changes LGTM once the other bits land.

@TimothyGu TimothyGu force-pushed the TimothyGu:url-whitespace branch to ddf2aa5 May 14, 2017

@TimothyGu

This comment has been minimized.

Copy link
Member Author

commented May 14, 2017

Upstream WPT PR was merged, this PR is ready for review :)

@TimothyGu TimothyGu changed the title WIP url: standard-conformant C0 control and whitespace handling url: standard-conformant C0 control and whitespace handling May 14, 2017

@joyeecheung

This comment has been minimized.

@TimothyGu

This comment has been minimized.

Copy link
Member Author

commented May 20, 2017

Landed in 841bb4c.

@TimothyGu TimothyGu closed this May 20, 2017

@TimothyGu TimothyGu deleted the TimothyGu:url-whitespace branch May 20, 2017

TimothyGu added a commit that referenced this pull request May 20, 2017
url: fix C0 control and whitespace handling
PR-URL: #12846
Fixes: #12825
Refs: web-platform-tests/wpt#5792
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.