Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: fix nits in README.md collaborators list #12866

Closed
wants to merge 1 commit into from

Conversation

@vsemozhetbyt
Copy link
Contributor

commented May 5, 2017

Checklist
Affected core subsystem(s)

meta

Fixes: #12865

cc @Fishrock123, @Qard, @imran-iq

@vsemozhetbyt vsemozhetbyt added the meta label May 5, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2017

@imran-iq Does your e-mail remain the same?

@lpinca
lpinca approved these changes May 6, 2017
README.md Outdated
@@ -278,7 +278,7 @@ more information about the governance of the Node.js project, see
**Isaac Z. Schlueter** <i@izs.me>
* [italoacasas](https://github.com/italoacasas) -
**Italo A. Casas** <me@italoacasas.com> (he/him)
* [iWuzHere](https://github.com/iWuzHere) -
* [imran-iq](https://github.com/imran-iq) -

This comment has been minimized.

Copy link
@addaleax

addaleax May 6, 2017

Member

I think you might want to re-order these alphabetically :)

This comment has been minimized.

Copy link
@vsemozhetbyt

vsemozhetbyt May 6, 2017

Author Contributor

Done)

@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:collaborators-nits branch to fff471e May 6, 2017

@gibfahn
gibfahn approved these changes May 6, 2017
@jasnell
jasnell approved these changes May 7, 2017
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2017

I am not sure to land this without @Fishrock123, @Qard, @imran-iq showing up.

@Qard

This comment has been minimized.

Copy link
Member

commented May 8, 2017

I'm happy either way on casing of my name. 👍

@gibfahn

This comment has been minimized.

Copy link
Member

commented May 8, 2017

I am not sure to land this without @Fishrock123, @Qard, @imran-iq showing up.

I think this is probably fine to land.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2017

Landed in: dd06246

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:collaborators-nits branch May 8, 2017

vsemozhetbyt added a commit that referenced this pull request May 8, 2017
meta: fix nits in README.md collaborators list
PR-URL: #12866
Fixes: #12865
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
meta: fix nits in README.md collaborators list
PR-URL: nodejs#12866
Fixes: nodejs#12865
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 20, 2017
meta: fix nits in README.md collaborators list
PR-URL: #12866
Fixes: #12865
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
meta: fix nits in README.md collaborators list
PR-URL: #12866
Fixes: #12865
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.