Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove obsolete lint config comments #12868

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented May 6, 2017

The max-len ESLint rule is configured to be forgiving for lines that
contain a regular expression literal. Remove disabling comments that are
no longer required in test-repl.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: remove obsolete lint config comments
The `max-len` ESLint rule is configured to be forgiving for lines that
contain a regular expression literal. Remove disabling comments that are
no longer required in test-repl.js
@lpinca
lpinca approved these changes May 6, 2017

@vsemozhetbyt vsemozhetbyt added the tools label May 6, 2017

@gibfahn
gibfahn approved these changes May 6, 2017
@refack
refack approved these changes May 6, 2017
@refack

This comment has been minimized.

Copy link
Member

commented May 6, 2017

@jasnell
jasnell approved these changes May 7, 2017
@cjihrig
cjihrig approved these changes May 8, 2017
Trott added a commit to Trott/io.js that referenced this pull request May 10, 2017
test: remove obsolete lint config comments
The `max-len` ESLint rule is configured to be forgiving for lines that
contain a regular expression literal. Remove disabling comments that are
no longer required in test-repl.js

PR-URL: nodejs#12868
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 10, 2017

Landed in 57a08e2

@Trott Trott closed this May 10, 2017

anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
test: remove obsolete lint config comments
The `max-len` ESLint rule is configured to be forgiving for lines that
contain a regular expression literal. Remove disabling comments that are
no longer required in test-repl.js

PR-URL: nodejs#12868
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 20, 2017

Feel free to backport if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.