Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
net: check and throw on error for getsockname #12871
@evanlucas Going through the errors that
These would point to a bug in Node, I say throwing an error is okay.
These won’t happen/also would point to a serious bug in Node. Should definitely make some noise.
Again, this probably never happens. Also, throwing seems better than returning invalid data here.
→ I think it’s safe to do this.