Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add skipIfInspectorDisabled to debugger-pid #12882

Closed
wants to merge 2 commits into from

Conversation

@danbev
Copy link
Member

commented May 7, 2017

Currently this test will fail if node was configured --without-ssl.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: add skipIfInspectorDisabled to debugger-pid
Currently this test will fail if node was configured --without-ssl.
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 7, 2017

@Trott
Trott approved these changes May 7, 2017
Copy link
Member

left a comment

LGTM if CI is green

@mscdex mscdex added the debugger label May 7, 2017

@refack
refack approved these changes May 7, 2017
@cjihrig
cjihrig approved these changes May 8, 2017
Copy link
Contributor

left a comment

LGTM. You could move this check right below the require('../common'); line, but it's not necessary.

@danbev

This comment has been minimized.

Copy link
Member Author

commented May 9, 2017

You could move this check right below the require('../common'); line, but it's not necessary.

Sounds good, I'll move it. Thanks.

danbev added a commit to danbev/node that referenced this pull request May 9, 2017
test: add skipIfInspectorDisabled to debugger-pid
Currently this test will fail if node was configured --without-ssl.

PR-URL: nodejs#12882
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 9, 2017

Landed in f72376d

@danbev danbev closed this May 9, 2017

@danbev danbev deleted the danbev:inspector-check-debugger-pid branch May 9, 2017

anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
test: add skipIfInspectorDisabled to debugger-pid
Currently this test will fail if node was configured --without-ssl.

PR-URL: nodejs#12882
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete

@gibfahn gibfahn added land-on-v6.x and removed land-on-v6.x labels Jun 20, 2017

@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 20, 2017

Depends on #11631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.