Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove useless default caught #12884

Closed
wants to merge 1 commit into from

Conversation

@JacksonTian
Copy link
Contributor

commented May 7, 2017

The variable caught's value is undefined, so the '|| caught' is
useless.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib/internel/bootstrap_node

@addaleax
Copy link
Member

left a comment

LGTM, but is “unless” in the commit message a typo?

@JacksonTian

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2017

Thanks @addaleax , let me fix it.

lib: remove useless default caught
The variable caught's value is undefined, so the '|| caught' is
useless.

@JacksonTian JacksonTian force-pushed the JacksonTian:caught branch to 934c66f May 7, 2017

@JacksonTian JacksonTian changed the title lib: remove unless default caught lib: remove useless default caught May 7, 2017

@mscdex

This comment has been minimized.

Copy link
Contributor

commented May 7, 2017

@refack
refack approved these changes May 7, 2017
@cjihrig
cjihrig approved these changes May 8, 2017
@lpinca
lpinca approved these changes May 8, 2017
@danbev
danbev approved these changes May 9, 2017
@gibfahn
gibfahn approved these changes May 9, 2017
@targos
targos approved these changes May 9, 2017
@jasnell
jasnell approved these changes May 9, 2017
jasnell added a commit that referenced this pull request May 9, 2017
lib: remove useless default caught
The variable caught's value is undefined, so the '|| caught' is
useless.

PR-URL: #12884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented May 9, 2017

Landed in 824fb49

@jasnell jasnell closed this May 9, 2017

@jasnell

This comment has been minimized.

Copy link
Member

commented May 9, 2017

(It's funny how many sign offs we can get on these small changes ;-) ...)

@lpinca

This comment has been minimized.

Copy link
Member

commented May 9, 2017

Ask a programmer to review 10 lines of code, they'll find 10 issues. Ask them to do 500 lines and they'll say it looks good.

anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
lib: remove useless default caught
The variable caught's value is undefined, so the '|| caught' is
useless.

PR-URL: nodejs#12884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 20, 2017
lib: remove useless default caught
The variable caught's value is undefined, so the '|| caught' is
useless.

PR-URL: #12884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
lib: remove useless default caught
The variable caught's value is undefined, so the '|| caught' is
useless.

PR-URL: #12884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017

@JacksonTian JacksonTian deleted the JacksonTian:caught branch Sep 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.