Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: refactor deprecated functions for readability #12910

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented May 9, 2017

This is a small refactor to make an object more readable (IMO).

Yeah, I spent a bit longer looking at the code and misunderstanding it
than I care to admit right now.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

fs

fs: refactor deprecated functions for readability
This is a small refactor to make an object more readable (IMO).

Yeah, I spent a bit longer looking at the code and misunderstanding it
than I care to admit right now.

@Trott Trott added the fs label May 9, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented May 9, 2017

I understand if this gets rejected as churn, but I do feel this is more readable.

Or maybe I just need more sleep.

@hiroppy
hiroppy approved these changes May 9, 2017
@gibfahn
gibfahn approved these changes May 9, 2017
@gibfahn

This comment has been minimized.

Copy link
Member

commented May 9, 2017

Looks cleaner to me, always in favour of readability.

@jasnell
jasnell approved these changes May 9, 2017
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 11, 2017

Trott added a commit to Trott/io.js that referenced this pull request May 11, 2017
fs: refactor deprecated functions for readability
This is a small refactor to make an object more readable (IMO).

Yeah, I spent a bit longer looking at the code and misunderstanding it
than I care to admit right now.

PR-URL: nodejs#12910
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 11, 2017

Landed in 6f449db

@Trott Trott closed this May 11, 2017

anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
fs: refactor deprecated functions for readability
This is a small refactor to make an object more readable (IMO).

Yeah, I spent a bit longer looking at the code and misunderstanding it
than I care to admit right now.

PR-URL: nodejs#12910
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.