Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace port in https address family test #12915

Closed
wants to merge 1 commit into from

Conversation

@arturgvieira
Copy link
Contributor

commented May 9, 2017

Replaced common.PORT with zero in the following test.
test-https-connect-address-family.js

Refs: #12376

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test https

@mscdex mscdex added the https label May 9, 2017

@mscdex

This comment has been minimized.

Copy link
Contributor

commented May 9, 2017

@hiroppy
hiroppy approved these changes May 9, 2017
@gibfahn
gibfahn approved these changes May 9, 2017
@lpinca
lpinca approved these changes May 9, 2017
@cjihrig
cjihrig approved these changes May 9, 2017
test: replace port in https address family test
Replaced common.PORT with zero in the following test.
test-https-connect-address-family.js

Refs: #12376

@arturgvieira arturgvieira changed the title test: replace common.PORT with zero test: replace port in https address family test May 10, 2017

@lpinca

This comment has been minimized.

lpinca added a commit to lpinca/node that referenced this pull request May 12, 2017
test: use dynamic port in test-https-connect-address-family
Remove common.PORT from test-https-connect-address-family to eliminate
possibility that a dynamic port used in another test will collide with
common.PORT.

PR-URL: nodejs#12915
Ref: nodejs#12376
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@lpinca

This comment has been minimized.

Copy link
Member

commented May 12, 2017

Landed in 56812c8.

@lpinca lpinca closed this May 12, 2017

@Trott Trott referenced this pull request May 12, 2017
55 of 64 tasks complete
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
test: use dynamic port in test-https-connect-address-family
Remove common.PORT from test-https-connect-address-family to eliminate
possibility that a dynamic port used in another test will collide with
common.PORT.

PR-URL: nodejs#12915
Ref: nodejs#12376
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
MylesBorins added a commit that referenced this pull request Jun 22, 2017
test: use dynamic port in test-https-connect-address-family
Remove common.PORT from test-https-connect-address-family to eliminate
possibility that a dynamic port used in another test will collide with
common.PORT.

PR-URL: #12915
Ref: #12376
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
test: use dynamic port in test-https-connect-address-family
Remove common.PORT from test-https-connect-address-family to eliminate
possibility that a dynamic port used in another test will collide with
common.PORT.

PR-URL: #12915
Ref: #12376
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.