New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: chunky http client should exit with 0 #12916

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@joyeecheung
Member

joyeecheung commented May 9, 2017

Previously when there is an error in the chunky client of the
http benchmark, the server would not check the exit code and
thus produce invalid results.

Fixes: #12903

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, benchmark

benchmark: chunky http client should exit with 0
Previously when there is an error in the chunky client of the
http benchmark, the server would not check the exit code and
thus produce invalid results.

Fixes: #12903
@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig approved these changes May 9, 2017

@jasnell

jasnell approved these changes May 9, 2017

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung May 13, 2017

Member

Landed in 3fa5d80, thanks!

Member

joyeecheung commented May 13, 2017

Landed in 3fa5d80, thanks!

joyeecheung added a commit that referenced this pull request May 13, 2017

benchmark: chunky http client should exit with 0
Previously when there is an error in the chunky client of the
http benchmark, the server would not check the exit code and
thus produce invalid results.

PR-URL: #12916
Fixes: #12903
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

anchnk added a commit to anchnk/node that referenced this pull request May 19, 2017

benchmark: chunky http client should exit with 0
Previously when there is an error in the chunky client of the
http benchmark, the server would not check the exit code and
thus produce invalid results.

PR-URL: nodejs#12916
Fixes: nodejs#12903
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment