New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addons: remove semicolons from after module definition #12919

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@gabrielschulhof
Contributor

gabrielschulhof commented May 9, 2017

Having semicolons there runs counter to our documentation and illicits
warnings in pedantic mode. This removes semicolons from after uses of
NODE_MODULE and NODE_MODULE_CONTEXT_AWARE_BUILTIN.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

addons, test, benchmark

addons: remove semicolons from after module definition
Having semicolons there runs counter to our documentation and illicits
warnings in pedantic mode. This removes semicolons from after uses of
NODE_MODULE and NODE_MODULE_CONTEXT_AWARE_BUILTIN.
@danbev

danbev approved these changes May 9, 2017

@aqrln

aqrln approved these changes May 9, 2017

@cjihrig

cjihrig approved these changes May 9, 2017

@jasnell

jasnell approved these changes May 9, 2017

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof May 15, 2017

Contributor

bump

Contributor

gabrielschulhof commented May 15, 2017

bump

@addaleax

This comment has been minimized.

Show comment
Hide comment
Member

addaleax commented May 15, 2017

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof May 15, 2017

Contributor

I cannot tell from https://ci.nodejs.org/job/node-test-commit-freebsd/9051/console whether this is anything I can fix.

Contributor

gabrielschulhof commented May 15, 2017

I cannot tell from https://ci.nodejs.org/job/node-test-commit-freebsd/9051/console whether this is anything I can fix.

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax May 15, 2017

Member

@gabrielschulhof The output you are looking for is at https://ci.nodejs.org/job/node-test-commit-freebsd/9051/nodes=freebsd11-x64/console – I know, the CI is a bit hard to navigate. Basically, the console output is only meaningful for the innermost jobs (e.g. freebsd10-64 and freebsd11-x64 which are both started by node-test-commit-freebsd in this case).

So, no, this isn’t anything you can fix, I’m landing this. :)

Member

addaleax commented May 15, 2017

@gabrielschulhof The output you are looking for is at https://ci.nodejs.org/job/node-test-commit-freebsd/9051/nodes=freebsd11-x64/console – I know, the CI is a bit hard to navigate. Basically, the console output is only meaningful for the innermost jobs (e.g. freebsd10-64 and freebsd11-x64 which are both started by node-test-commit-freebsd in this case).

So, no, this isn’t anything you can fix, I’m landing this. :)

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax May 15, 2017

Member

Landed in 2767209

Member

addaleax commented May 15, 2017

Landed in 2767209

@addaleax addaleax closed this May 15, 2017

addaleax added a commit that referenced this pull request May 15, 2017

addons: remove semicolons from after module definition
Having semicolons there runs counter to our documentation and illicits
warnings in pedantic mode. This removes semicolons from after uses of
NODE_MODULE and NODE_MODULE_CONTEXT_AWARE_BUILTIN.

PR-URL: #12919
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>

@gabrielschulhof gabrielschulhof deleted the gabrielschulhof:remove-semicolons branch May 15, 2017

anchnk added a commit to anchnk/node that referenced this pull request May 19, 2017

addons: remove semicolons from after module definition
Having semicolons there runs counter to our documentation and illicits
warnings in pedantic mode. This removes semicolons from after uses of
NODE_MODULE and NODE_MODULE_CONTEXT_AWARE_BUILTIN.

PR-URL: nodejs#12919
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Jun 22, 2017

Member

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

Member

MylesBorins commented Jun 22, 2017

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Jul 6, 2017

addons: remove semicolons from after module definition
Having semicolons there runs counter to our documentation and illicits
warnings in pedantic mode. This removes semicolons from after uses of
NODE_MODULE and NODE_MODULE_CONTEXT_AWARE_BUILTIN.

PR-URL: nodejs#12919
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>

MylesBorins added a commit that referenced this pull request Jul 10, 2017

addons: remove semicolons from after module definition
Having semicolons there runs counter to our documentation and illicits
warnings in pedantic mode. This removes semicolons from after uses of
NODE_MODULE and NODE_MODULE_CONTEXT_AWARE_BUILTIN.

PR-URL: #12919
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>

MylesBorins added a commit that referenced this pull request Jul 11, 2017

addons: remove semicolons from after module definition
Having semicolons there runs counter to our documentation and illicits
warnings in pedantic mode. This removes semicolons from after uses of
NODE_MODULE and NODE_MODULE_CONTEXT_AWARE_BUILTIN.

PR-URL: #12919
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jul 18, 2017

Merged

v6.11.2 proposal #14356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment