Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
addons: remove semicolons from after module definition #12919
Having semicolons there runs counter to our documentation and illicits
Affected core subsystem(s)
addons, test, benchmark
I cannot tell from https://ci.nodejs.org/job/node-test-commit-freebsd/9051/console whether this is anything I can fix.
@gabrielschulhof The output you are looking for is at https://ci.nodejs.org/job/node-test-commit-freebsd/9051/nodes=freebsd11-x64/console – I know, the CI is a bit hard to navigate. Basically, the console output is only meaningful for the innermost jobs (e.g. freebsd10-64 and freebsd11-x64 which are both started by node-test-commit-freebsd in this case).
So, no, this isn’t anything you can fix, I’m landing this. :)