New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in streams.md #12924

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@glennschler
Contributor

glennschler commented May 9, 2017

Replaces the misplaced word 'in' with 'is' in description of Readable event:error

Checklist
  • [x ] documentation is changed or added
  • [ x] commit message follows commit guidelines
Affected core subsystem(s)
  • doc
doc: fix typo in streams.md
Slight grammar change to the readable event:`error`
@lpinca

lpinca approved these changes May 9, 2017

@cjihrig

cjihrig approved these changes May 9, 2017

This doesn't need to wait 48 hours.

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt May 9, 2017

Member

Landed in e429f9a

Member

vsemozhetbyt commented May 9, 2017

Landed in e429f9a

vsemozhetbyt added a commit that referenced this pull request May 9, 2017

doc: fix typo in streams.md
Slight grammar change to the readable event:`error`

PR-URL: #12924
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

anchnk added a commit to anchnk/node that referenced this pull request May 19, 2017

doc: fix typo in streams.md
Slight grammar change to the readable event:`error`

PR-URL: nodejs#12924
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

@jasnell jasnell referenced this pull request May 11, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

gibfahn added a commit that referenced this pull request Jun 20, 2017

doc: fix typo in streams.md
Slight grammar change to the readable event:`error`

PR-URL: #12924
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

MylesBorins added a commit that referenced this pull request Jul 11, 2017

doc: fix typo in streams.md
Slight grammar change to the readable event:`error`

PR-URL: #12924
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jul 18, 2017

Merged

v6.11.2 proposal #14356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment