New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: check for time precision in common.js #12934

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@Trott
Member

Trott commented May 9, 2017

Some benchmark tests are failing intermittently, possibly due to
hrtime() imprecision on particular hosts. This change will confirm or
refute that as the root cause the next time the test fails on CI. Either
way, it's a valid check.

Refs: #12497
Refs: #12433

/cc @addaleax @joyeecheung

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark test

benchmark: check for time precision in common.js
Some benchmark tests are failing intermittently, possibly due to
hrtime() imprecision on particular hosts. This change will confirm or
refute that as the root cause the next time the test fails on CI. Either
way, it's a valid check.

Refs: #12497
Refs: #12433
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell May 9, 2017

Member

Hmmm... do we want to fail or skip on those?

Member

jasnell commented May 9, 2017

Hmmm... do we want to fail or skip on those?

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott May 9, 2017

Member

Hmmm... do we want to fail or skip on those?

If it is confirmed as the source of the error, we'll probably add something to the start of the test to check the hrtime() precision and skip if it is not sufficiently precise. But first I want to confirm that this is actually the source of the problem.

Member

Trott commented May 9, 2017

Hmmm... do we want to fail or skip on those?

If it is confirmed as the source of the error, we'll probably add something to the start of the test to check the hrtime() precision and skip if it is not sufficiently precise. But first I want to confirm that this is actually the source of the problem.

@Trott

This comment has been minimized.

Show comment
Hide comment

Trott added a commit to Trott/io.js that referenced this pull request May 11, 2017

benchmark: check for time precision in common.js
Some benchmark tests are failing intermittently, possibly due to
hrtime() imprecision on particular hosts. This change will confirm or
refute that as the root cause the next time the test fails on CI. Either
way, it's a valid check.

PR-URL: nodejs#12934
Ref: nodejs#12497
Ref: nodejs#12433
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott May 11, 2017

Member

Landed in a82e0e6

Member

Trott commented May 11, 2017

Landed in a82e0e6

@Trott Trott closed this May 11, 2017

anchnk added a commit to anchnk/node that referenced this pull request May 19, 2017

benchmark: check for time precision in common.js
Some benchmark tests are failing intermittently, possibly due to
hrtime() imprecision on particular hosts. This change will confirm or
refute that as the root cause the next time the test fails on CI. Either
way, it's a valid check.

PR-URL: nodejs#12934
Ref: nodejs#12497
Ref: nodejs#12433
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment