Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add common.mustCall() to NAPI exception test #12959

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@Trott
Copy link
Member

commented May 11, 2017

Use common.mustCall() to confirm that function is invoked.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: add common.mustCall() to NAPI exception test
Use `common.mustCall()` to confirm that function is invoked.
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 13, 2017

Trott added a commit to Trott/io.js that referenced this pull request May 13, 2017

test: add common.mustCall() to NAPI exception test
Use `common.mustCall()` to confirm that function is invoked.

PR-URL: nodejs#12959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 13, 2017

Landed in 9516aa1

@Trott Trott closed this May 13, 2017

anchnk added a commit to anchnk/node that referenced this pull request May 19, 2017

test: add common.mustCall() to NAPI exception test
Use `common.mustCall()` to confirm that function is invoked.

PR-URL: nodejs#12959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 12, 2018

test: add common.mustCall() to NAPI exception test
Use `common.mustCall()` to confirm that function is invoked.

PR-URL: nodejs#12959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 31, 2018

test: add common.mustCall() to NAPI exception test
Use `common.mustCall()` to confirm that function is invoked.

PR-URL: nodejs#12959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018

test: add common.mustCall() to NAPI exception test
Use `common.mustCall()` to confirm that function is invoked.

PR-URL: nodejs#12959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Apr 16, 2018

test: add common.mustCall() to NAPI exception test
Use `common.mustCall()` to confirm that function is invoked.

Backport-PR-URL: #19447
PR-URL: #12959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Apr 16, 2018

Merged

v6.14.2 proposal #19996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.