New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit Error.captureStackTrace html comment #12962

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
10 participants
@arturgvieira
Contributor

arturgvieira commented May 11, 2017

Edit to the comment in the stack trace capture, highlighting the use of
the constructorOpt argument in errors.md

Ref: nodejs#12289

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
@lpinca

lpinca approved these changes May 11, 2017

Show outdated Hide outdated doc/api/errors.md
@@ -238,7 +238,7 @@ function MyError() {
// Without passing MyError to captureStackTrace, the MyError
// frame would show up in the .stack property. By passing
// the constructor, we omit that frame and all frames above it.
// the constructor, we omit that frame, and retain all frames above it.

This comment has been minimized.

@addaleax

addaleax May 11, 2017

Member

This changes the meaning of this sentence now, you would want to replace “above” with “below” if you talk about the retained frames

@addaleax

addaleax May 11, 2017

Member

This changes the meaning of this sentence now, you would want to replace “above” with “below” if you talk about the retained frames

This comment has been minimized.

@arturgvieira

arturgvieira May 11, 2017

Contributor

@addaleax Sounds good, will update the PR. Thank you

@arturgvieira

arturgvieira May 11, 2017

Contributor

@addaleax Sounds good, will update the PR. Thank you

doc: edit Error.captureStackTrace html comment
Edit to the comment in the stack trace capture, highlighting the use of
the constructorOpt argument in errors.md

Ref: nodejs#12289
@arturgvieira

This comment has been minimized.

Show comment
Hide comment
@arturgvieira

arturgvieira May 11, 2017

Contributor

@addaleax All done. I updated the PR, replacing "above" with "below".

Contributor

arturgvieira commented May 11, 2017

@addaleax All done. I updated the PR, replacing "above" with "below".

@addaleax

LGTM, thank you!

@mhdawson

LGTM

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack May 19, 2017

Member

Dismissed my review. In the context of the whole text, my comment is less critical.

Member

refack commented May 19, 2017

Dismissed my review. In the context of the whole text, my comment is less critical.

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax May 21, 2017

Member

Landed in ef71824, thanks for the PR!

Member

addaleax commented May 21, 2017

Landed in ef71824, thanks for the PR!

@addaleax addaleax closed this May 21, 2017

addaleax added a commit that referenced this pull request May 21, 2017

doc: edit Error.captureStackTrace html comment
Edit to the comment in the stack trace capture, highlighting the use of
the constructorOpt argument in errors.md

Fixes: #12289
PR-URL: #12962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben.bridgewater@fintura.de>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

MylesBorins added a commit that referenced this pull request Jul 17, 2017

doc: edit Error.captureStackTrace html comment
Edit to the comment in the stack trace capture, highlighting the use of
the constructorOpt argument in errors.md

Fixes: #12289
PR-URL: #12962
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben.bridgewater@fintura.de>

@MylesBorins MylesBorins referenced this pull request Jul 18, 2017

Merged

v6.11.2 proposal #14356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment