Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
src: add HAVE_OPENSSL guard to crypto providers #12967
When configured --without-ssl node_crypto.h will not be included but
These will be included as providers which will cause
This commit suggest adding a guard and exclude the providers that are
Affected core subsystem(s)
I'm running the test on windows locally to see if I can reproduce the windows-fanned error reported which does look related:
ok 1 parallel/test-assert-fail --- duration_ms: 0.145 ... not ok 2 parallel/test-async-wrap-getasyncid --- duration_ms: 0.262 severity: fail stack: |- Mismatched <anonymous> function calls. Expected 1, actual 0. at Object.<anonymous> (c:\workspace\node-test-binary-windows\RUN_SUBSET\3\VS_VERSION\vs2015\label\win2008r2\test\parallel\test-async-wrap-getasyncid.js:155:42) at Module._compile (module.js:569:30) at Object.Module._extensions..js (module.js:580:10) at Module.load (module.js:503:32) at tryModuleLoad (module.js:466:12) at Function.Module._load (module.js:458:3) at Function.Module.runMain (module.js:605:10) at startup (bootstrap_node.js:144:16) at bootstrap_node.js:561:3 (node:2036) [DEP0064] DeprecationWarning: tls.createSecurePair() is deprecated. Please use tls.Socket instead.
The test/osx I'm not sure about:
not ok 589 parallel/test-http-res-write-after-end --- duration_ms: 7.7 severity: crashed stack: |- oh no! exit code: CRASHED (Signal: 9) ... not ok 590 parallel/test-http-request-methods --- duration_ms: 7.61 severity: crashed stack: |- oh no! exit code: CRASHED (Signal: 9)
I don't see this locally but lately I do get test failures now and again.