Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make the rest of tests path-independent #12972

Closed

Conversation

@vsemozhetbyt
Copy link
Contributor

commented May 11, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Permit spaces in paths to a Node.js executable and test scripts.

Fixes: #12773

@vsemozhetbyt vsemozhetbyt added the test label May 11, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2017

@Trott
Trott approved these changes May 11, 2017
Copy link
Member

left a comment

LGTM if CI is green

@Trott

This comment has been minimized.

Copy link
Member

commented May 11, 2017

@nodejs/testing

This is specifically about permitting spaces in the path, right? Might be good to make that explicit in the PR description and commit message.

test: make the rest of tests path-independent
Permit spaces in paths to a Node.js executable and test scripts.

Fixes: #12773

@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:test-node-path-independent branch to 5e73b3e May 11, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2017

Landed in 945f208

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:test-node-path-independent branch May 14, 2017

vsemozhetbyt added a commit that referenced this pull request May 14, 2017
test: make the rest of tests path-independent
Permit spaces in paths to a Node.js executable and test scripts.

PR-URL: #12972
Fixes: #12773
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
test: make the rest of tests path-independent
Permit spaces in paths to a Node.js executable and test scripts.

PR-URL: nodejs#12972
Fixes: nodejs#12773
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jun 22, 2017

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace the backport request label with do-not-land if it shouldn't land

vsemozhetbyt added a commit to vsemozhetbyt/node that referenced this pull request Jun 22, 2017
test: make the rest of tests path-independent
Permit spaces in paths to a Node.js executable and test scripts.

PR-URL: nodejs#12972
Fixes: nodejs#12773
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2017

MylesBorins added a commit that referenced this pull request Jul 10, 2017
test: make the rest of tests path-independent
Permit spaces in paths to a Node.js executable and test scripts.

PR-URL: #12972
Fixes: #12773
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
test: make the rest of tests path-independent
Permit spaces in paths to a Node.js executable and test scripts.

PR-URL: #12972
Fixes: #12773
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.