Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add not-called check to heap-profiler test #12985

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented May 11, 2017

Add common.mustNotCall() to make sure there aren't any strange
shenanians in the C++ test that would cause the function to execute when
it shouldn't.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test addons

test: add not-called check to heap-profiler test
Add `common.mustNotCall()` to make sure there aren't any strange
shenanians in the C++ test that would cause the function to execute when
it shouldn't.
@refack
refack approved these changes May 12, 2017
@lpinca
lpinca approved these changes May 12, 2017
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 13, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented May 13, 2017

CI again: https://ci.nodejs.org/job/node-test-pull-request/8066/

CI looks like it was having multiple difficulties with builds unrelated to this change. Let's run it again.

CI: https://ci.nodejs.org/job/node-test-pull-request/8067/

@refack

This comment has been minimized.

Copy link
Member

commented May 14, 2017

Windows fail is a flake.

Trott added a commit to Trott/io.js that referenced this pull request May 15, 2017
test: add not-called check to heap-profiler test
Add `common.mustNotCall()` to make sure there aren't any strange
shenanians in the C++ test that would cause the function to execute when
it shouldn't.

PR-URL: nodejs#12985
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 15, 2017

Landed in b7bc09f

@Trott Trott closed this May 15, 2017

anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
test: add not-called check to heap-profiler test
Add `common.mustNotCall()` to make sure there aren't any strange
shenanians in the C++ test that would cause the function to execute when
it shouldn't.

PR-URL: nodejs#12985
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
MylesBorins added a commit that referenced this pull request Jun 22, 2017
test: add not-called check to heap-profiler test
Add `common.mustNotCall()` to make sure there aren't any strange
shenanians in the C++ test that would cause the function to execute when
it shouldn't.

PR-URL: #12985
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
test: add not-called check to heap-profiler test
Add `common.mustNotCall()` to make sure there aren't any strange
shenanians in the C++ test that would cause the function to execute when
it shouldn't.

PR-URL: #12985
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.