Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add hasCrypto check to https-agent-constructor #12987

Closed

Conversation

@danbev
Copy link
Member

commented May 12, 2017

Currently this test will fail with the following error message when
configured --without-ssl:

Error: Node.js is not compiled with openssl crypto support

This commit checks for crypto and skips this tests if such support
is not available.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: add hasCrypto check to https-agent-constructor
Currently this test will fail with the following error message when
configured --without-ssl:
Error: Node.js is not compiled with openssl crypto support

This commit checks for crypto and skips this tests if such support
is not available.
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 12, 2017

@mscdex mscdex added the https label May 12, 2017

@cjihrig
Copy link
Contributor

left a comment

Oops. LGTM

@lpinca
lpinca approved these changes May 12, 2017
danbev added a commit to danbev/node that referenced this pull request May 14, 2017
test: add hasCrypto check to https-agent-constructor
Currently this test will fail with the following error message when
configured --without-ssl:
Error: Node.js is not compiled with openssl crypto support

This commit checks for crypto and skips this tests if such support
is not available.

PR-URL: nodejs#12987
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 14, 2017

Landed in b5ae22d

@danbev danbev closed this May 14, 2017

anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
test: add hasCrypto check to https-agent-constructor
Currently this test will fail with the following error message when
configured --without-ssl:
Error: Node.js is not compiled with openssl crypto support

This commit checks for crypto and skips this tests if such support
is not available.

PR-URL: nodejs#12987
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete

@danbev danbev deleted the danbev:https-agent-constructor-crypto-check branch Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.