Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace port in dgram send address types test #13007

Closed
wants to merge 1 commit into from

Conversation

@arturgvieira
Copy link
Contributor

commented May 12, 2017

Replaced common.PORT in the following test.
test-dgram-send-address-types.js

Ref: #12376

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test dgram

@hiroppy hiroppy added the dgram label May 13, 2017

test/parallel/test-dgram-send-address-types.js Outdated
assert.throws(() => {
client.send(buf, port, true);
}, expectedError);
const onMessage = common.mustCall((err, bytes) => {

This comment has been minimized.

Copy link
@lpinca

lpinca May 13, 2017

Member

Nit: can you please move this at the top of the file? before creating the socket.

test/parallel/test-dgram-send-address-types.js Outdated
assert.strictEqual(bytes, buf.length);
}, 6);

const expectedError =

This comment has been minimized.

Copy link
@lpinca

lpinca May 13, 2017

Member

Ditto.

@lpinca
lpinca approved these changes May 13, 2017
test: replace port in dgram send address types test
Replaced common.PORT in the following test.
test-dgram-send-address-types.js

Ref: #12376
@arturgvieira

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2017

@lpinca All done, I moved those two items towards the top of the file.

@lpinca

This comment has been minimized.

@lpinca

This comment has been minimized.

Copy link
Member

commented May 22, 2017

Landed in 281de19.

@lpinca lpinca closed this May 22, 2017

lpinca added a commit that referenced this pull request May 22, 2017
test: use dynamic port in test-dgram-send-address-types
Remove common.PORT from test-dgram-send-address-types to eliminate
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #13007
Refs: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott referenced this pull request May 22, 2017
55 of 64 tasks complete
jasnell added a commit that referenced this pull request May 23, 2017
test: use dynamic port in test-dgram-send-address-types
Remove common.PORT from test-dgram-send-address-types to eliminate
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #13007
Refs: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell added a commit that referenced this pull request May 23, 2017
test: use dynamic port in test-dgram-send-address-types
Remove common.PORT from test-dgram-send-address-types to eliminate
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #13007
Refs: #12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.