New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: remove redundant timers benchmark #13009

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@Trott
Member

Trott commented May 13, 2017

The immediate.js benchmark with type set to depth measures the same
thing as set-immediate-depth.js. Remove the redundancy.`

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

timers benchmark

benchmark: remove redundant timers benchmark
The immediate.js benchmark with `type` set to `depth` measures the same
thing as set-immediate-depth.js. Remove the redundancy.`
@Trott

This comment has been minimized.

Show comment
Hide comment
@refack

refack approved these changes May 15, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott May 17, 2017

Member

Landed in f2ba06d

Member

Trott commented May 17, 2017

Landed in f2ba06d

@Trott Trott closed this May 17, 2017

Trott added a commit to Trott/io.js that referenced this pull request May 17, 2017

benchmark: remove redundant timers benchmark
The immediate.js benchmark with `type` set to `depth` measures the same
thing as set-immediate-depth.js. Remove the redundancy.`

PR-URL: nodejs#13009
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

anchnk added a commit to anchnk/node that referenced this pull request May 19, 2017

benchmark: remove redundant timers benchmark
The immediate.js benchmark with `type` set to `depth` measures the same
thing as set-immediate-depth.js. Remove the redundancy.`

PR-URL: nodejs#13009
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment