Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: track callback invocations #13010

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented May 13, 2017

Use common.mustCall() and common.mustNotCall() to check that
callbacks are invoked the expected number of times in
test-net-listen-shared-ports.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test net

test: track callback invocations
Use `common.mustCall()` and `common.mustNotCall()` to check that
callbacks are invoked the expected number of times in
test-net-listen-shared-ports.
@lpinca
lpinca approved these changes May 13, 2017
@refack
refack approved these changes May 14, 2017
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 17, 2017

@refack

This comment has been minimized.

Copy link
Member

commented May 17, 2017

Rerun linux (previous run had tap parse issue): https://ci.nodejs.org/job/node-test-commit-linux/9943/

@addaleax

This comment has been minimized.

Copy link
Member

commented May 18, 2017

Landed in 7e5ed8b

@addaleax addaleax closed this May 18, 2017

addaleax added a commit that referenced this pull request May 18, 2017
test: track callback invocations
Use `common.mustCall()` and `common.mustNotCall()` to check that
callbacks are invoked the expected number of times in
test-net-listen-shared-ports.

PR-URL: #13010
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@Trott Trott referenced this pull request May 19, 2017
2 of 2 tasks complete
@refack

This comment has been minimized.

Copy link
Member

commented May 19, 2017

Cross reference #13100
(there a hidden bug when worker1 binds to port 0)

anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
test: track callback invocations
Use `common.mustCall()` and `common.mustNotCall()` to check that
callbacks are invoked the expected number of times in
test-net-listen-shared-ports.

PR-URL: nodejs#13010
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
MylesBorins added a commit that referenced this pull request Jul 17, 2017
test: track callback invocations
Use `common.mustCall()` and `common.mustNotCall()` to check that
callbacks are invoked the expected number of times in
test-net-listen-shared-ports.

PR-URL: #13010
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.