New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document method for reverting commits #13015

Merged
merged 1 commit into from May 16, 2017

Conversation

Projects
None yet
9 participants
@gibfahn
Member

gibfahn commented May 13, 2017

Fixes: #12979
Refs: #4679 (comment)

Checklist
Affected core subsystem(s)

doc

@cjihrig

LGTM with a suggestion.

Show outdated Hide outdated COLLABORATOR_GUIDE.md
@@ -252,6 +252,10 @@ not can often be based on many complex factors that are not easily codified. It
is also possible that the breaking commit can be labeled retroactively as a
semver-major change that will not be backported to Current or LTS branches.
Commits are reverted with `git revert <HASH>`, or `git revert <FROM>..<TO>` for

This comment has been minimized.

@cjihrig

cjihrig May 13, 2017

Contributor

A subsection header might be appropriate here.

@cjihrig

cjihrig May 13, 2017

Contributor

A subsection header might be appropriate here.

This comment has been minimized.

@gibfahn

gibfahn May 13, 2017

Member

Done

@gibfahn
@Trott

Trott approved these changes May 13, 2017

LGTM

@joyeecheung

Probably a bit obvious but...should we mention that we do need to open PRs for reverting commits?

@lpinca

lpinca approved these changes May 14, 2017

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn May 14, 2017

Member

Probably a bit obvious but...should we mention that we do need to open PRs for reverting commits?

@joyeecheung why not! Done

Member

gibfahn commented May 14, 2017

Probably a bit obvious but...should we mention that we do need to open PRs for reverting commits?

@joyeecheung why not! Done

@gibfahn gibfahn closed this May 16, 2017

@gibfahn gibfahn deleted the gibfahn:doc-revert branch May 16, 2017

doc: document method for reverting commits
PR-URL: #13015
Fixes: #12979
Refs: #4679 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn restored the gibfahn:doc-revert branch May 16, 2017

@gibfahn gibfahn reopened this May 16, 2017

@gibfahn gibfahn merged commit 92f3b30 into nodejs:master May 16, 2017

@gibfahn gibfahn deleted the gibfahn:doc-revert branch May 16, 2017

anchnk added a commit to anchnk/node that referenced this pull request May 19, 2017

doc: document method for reverting commits
PR-URL: nodejs#13015
Fixes: nodejs#12979
Refs: nodejs#4679 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

MylesBorins added a commit that referenced this pull request Jun 22, 2017

doc: document method for reverting commits
PR-URL: #13015
Fixes: #12979
Refs: #4679 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Jul 11, 2017

doc: document method for reverting commits
PR-URL: #13015
Fixes: #12979
Refs: #4679 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jul 18, 2017

Merged

v6.11.2 proposal #14356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment