Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-net-GH-5504 #13025

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented May 14, 2017

  • Improve comments describing test.
  • Remove unnecessary common.noop
  • Remove confusing scoping of c identifier
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test net

test: refactor test-net-GH-5504
* Improve comments describing test.
* Remove unnecessary `common.noop`
* Remove confusing scoping of `c` identifier

@Trott Trott added net test labels May 14, 2017

@refack
refack approved these changes May 14, 2017
@lpinca
lpinca approved these changes May 15, 2017
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 19, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented May 20, 2017

Landed in 5254975.

@Trott Trott closed this May 20, 2017

Trott added a commit to Trott/io.js that referenced this pull request May 20, 2017
test: refactor test-net-nodejsGH-5504
* Improve comments describing test.
* Remove unnecessary `common.noop`
* Remove confusing scoping of `c` identifier

PR-URL: nodejs#13025
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.