New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: clean up napi build in test-addons-clean #13034

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@joyeecheung
Copy link
Member

joyeecheung commented May 15, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Refs: #13031

Affected core subsystem(s)

build

@mscdex mscdex added the n-api label May 15, 2017

@danbev

danbev approved these changes May 15, 2017

@gibfahn

This comment has been minimized.

Copy link
Member

gibfahn commented May 15, 2017

@refack

This comment has been minimized.

Copy link
Member

refack commented May 15, 2017

So you're exempt from dealing with vcbuild.bat because apparently we (Windows people) don't get any clean logic at all 😢
That brings up the question? way do you have cleaning targets in Makefile? git clean does a very good job?

@refack

refack approved these changes May 15, 2017

Copy link
Member

refack left a comment

Approving no need for changes in vcbuild.bat

@joyeecheung

This comment has been minimized.

Copy link
Member Author

joyeecheung commented May 15, 2017

@refack git clean doesn't clean up files that are gitignored though (like /test/addons/??_*/)..

I agree there can be similar rules in vcbuild.bat, but that can be solved in another PR, no?

@refack

This comment has been minimized.

Copy link
Member

refack commented May 15, 2017

@refack git clean doesn't clean up files that are gitignored though (like /test/addons/??_*/)..

-x cleans ignored files (which is good enough for me).

I agree there can be similar rules in vcbuild.bat, but that can be solved in another PR, no?

IMHO there's no need... (If there was any logic IMHO is should have been changed here...)

@Trott Trott referenced this pull request May 15, 2017

Closed

test: fix flaky test-net-connect-local-error #12964

2 of 3 tasks complete
@mhdawson
Copy link
Member

mhdawson left a comment

LGTM

@gibfahn

This comment has been minimized.

Copy link
Member

gibfahn commented May 15, 2017

That brings up the question? way do you have cleaning targets in Makefile? git clean does a very good job?

Interesting question, not sure if there's any difference between the two, except that if you've added some new files and not committed yet, make clean won't delete them but git clean -fdx will (I think).

The subtargets like clean-addons are useful though, you can wipe out the addons build files without having to rebuild node entirely.

@mhdawson

This comment has been minimized.

Copy link
Member

mhdawson commented May 16, 2017

@refack

This comment has been minimized.

Copy link
Member

refack commented May 16, 2017

Interesting question, not sure if there's any difference between the two, except that if you've added some new files and not committed yet, make clean won't delete them but git clean -fdx will (I think).

The subtargets like clean-addons are useful though, you can wipe out the addons build files without having to rebuild node entirely.

Well then you enjoy your well-thought-of Makefile targets 😞

@joyeecheung

This comment has been minimized.

Copy link
Member Author

joyeecheung commented May 16, 2017

@refack Hmm..I didn't realize that git clean -x does the job as well, sorry. Although I still think this is useful when working on addon tests.

@mhdawson

This comment has been minimized.

Copy link
Member

mhdawson commented May 16, 2017

I tend to agree that since there is a clean target for regular addons, bringing napi in line with that makes sense. If we decide that there is a better approach then a PR could address that for both the original addons and napi-addons.

Any objections to landing based on that approach ?

@refack

This comment has been minimized.

Copy link
Member

refack commented May 16, 2017

I was always +1, and as I said no need to add to vcbuild.bat

@mhdawson

This comment has been minimized.

Copy link
Member

mhdawson commented May 17, 2017

Landed as 6342988

@mhdawson mhdawson closed this May 17, 2017

mhdawson added a commit that referenced this pull request May 17, 2017

build: clean up napi build in test-addons-clean
PR-URL: #13034
Ref: #13031
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rajaram Gaunker <rajarams@gmail.com>

anchnk added a commit to anchnk/node that referenced this pull request May 19, 2017

build: clean up napi build in test-addons-clean
PR-URL: nodejs#13034
Ref: nodejs#13031
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rajaram Gaunker <rajarams@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment