New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking from toc to subsection for 4.8.x releases #13039

Closed
wants to merge 1 commit into
base: master
from

Conversation

@frlan
Contributor

frlan commented May 15, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt May 15, 2017

Member

@frlan Thank you!

Dear reviewers, please, let me know if this can be landed without the common delay.

Member

vsemozhetbyt commented May 15, 2017

@frlan Thank you!

Dear reviewers, please, let me know if this can be landed without the common delay.

@danbev

danbev approved these changes May 15, 2017

@lpinca

lpinca approved these changes May 15, 2017

@gibfahn gibfahn self-assigned this May 18, 2017

@gibfahn

This comment has been minimized.

Show comment
Hide comment
Member

gibfahn commented May 18, 2017

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn May 18, 2017

Member

Landed in 5de722a

Thanks for the PR @frlan !

Member

gibfahn commented May 18, 2017

Landed in 5de722a

Thanks for the PR @frlan !

@gibfahn gibfahn closed this May 18, 2017

gibfahn added a commit that referenced this pull request May 18, 2017

doc: fix links from ToC to subsection for 4.8.x
PR-URL: #13039
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

anchnk added a commit to anchnk/node that referenced this pull request May 19, 2017

doc: fix links from ToC to subsection for 4.8.x
PR-URL: nodejs#13039
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment