New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove unused/duplicated reference links #13066

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@watilde
Member

watilde commented May 16, 2017

Summary

I noticed some un-styled markdown at #12756, and the original PR may take more time. To avoid more conflicts and make the diff a bit small, it would be nice if we can take the docs fix commits from it. Then I removed the unused/duplicated reference links.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Show outdated Hide outdated doc/api/fs.md
@@ -2938,7 +2937,6 @@ The following constants are meant for use with the [`fs.Stats`][] object's
[`util.inspect(stats)`]: util.html#util_util_inspect_object_options
[`util.promisify()`]: util.html#util_util_promisify_original
[Caveats]: #fs_caveats
[Common System Errors]: errors.html#errors_common_system_errors

This comment has been minimized.

@cjihrig

cjihrig May 16, 2017

Contributor

Are you sure all of these are correct? This one, for example, appears to be used.

@cjihrig

cjihrig May 16, 2017

Contributor

Are you sure all of these are correct? This one, for example, appears to be used.

This comment has been minimized.

@watilde

watilde May 17, 2017

Member

Oops, it was used indeed. I just updated it and re-check them all manually. Thanks!

@watilde

watilde May 17, 2017

Member

Oops, it was used indeed. I just updated it and re-check them all manually. Thanks!

@cjihrig

LGTM assuming these are all unused :-D

@@ -2963,7 +2963,6 @@ callback invocation, even if it has been successfully cancelled.
[`napi_create_range_error`]: #n_api_napi_create_range_error
[`napi_create_reference`]: #n_api_napi_create_reference
[`napi_create_type_error`]: #n_api_napi_create_type_error
[`napi_define_class`]: #n_api_napi_define_class

This comment has been minimized.

@lpinca

lpinca May 19, 2017

Member

This seems to be used.

@lpinca

lpinca May 19, 2017

Member

This seems to be used.

This comment has been minimized.

@watilde

watilde May 20, 2017

Member

It's duplicated.

@watilde

watilde May 20, 2017

Member

It's duplicated.

This comment has been minimized.

@lpinca

lpinca May 20, 2017

Member

Ops, sorry.

@lpinca

lpinca May 20, 2017

Member

Ops, sorry.

@@ -1061,7 +1061,6 @@ Returns true if input is a version 6 IP address, otherwise returns false.
[`net.Server`]: #net_class_net_server
[`net.Socket`]: #net_class_net_socket
[`net.connect()`]: #net_net_connect
[`net.connect()`]: #net_net_connect

This comment has been minimized.

@lpinca

lpinca May 19, 2017

Member

Ditto.

@lpinca

lpinca May 19, 2017

Member

Ditto.

This comment has been minimized.

@watilde

watilde May 20, 2017

Member

It's also duplicated.

@watilde

watilde May 20, 2017

Member

It's also duplicated.

@lpinca

lpinca approved these changes May 20, 2017

@watilde

This comment has been minimized.

Show comment
Hide comment
@watilde

This comment has been minimized.

Show comment
Hide comment
@watilde

watilde May 20, 2017

Member

landed in bfade5a.

Member

watilde commented May 20, 2017

landed in bfade5a.

@watilde watilde closed this May 20, 2017

@watilde watilde deleted the watilde:feature/docs branch May 20, 2017

watilde added a commit that referenced this pull request May 20, 2017

doc: remove unused/duplicated reference links
PR-URL: #13066
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This was referenced May 26, 2017

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Jul 17, 2017

Member

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

Member

MylesBorins commented Jul 17, 2017

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 12, 2018

doc: remove unused/duplicated reference links
This applies portions of bfade5a that
are relevant to N-API.

PR-URL: nodejs#13066
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 31, 2018

doc: remove unused/duplicated reference links
PR-URL: nodejs#13066
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment