New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update doc to remove usage of "you" #13067

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@mhdawson
Member

mhdawson commented May 16, 2017

As per style guide avoid the use of you, your etc.
Rational as per: http://www2.ivcc.edu/rambo/tip_formal_writing_voice.htm

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

doc: update doc to remove usage of "you"
As per style guide avoid the use of you, your etc.
Rational as per: http://www2.ivcc.edu/rambo/tip_formal_writing_voice.htm
@Trott

This comment has been minimized.

Show comment
Hide comment
Member

Trott commented May 17, 2017

@lpinca

lpinca approved these changes May 17, 2017

@aqrln

aqrln approved these changes May 18, 2017

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson May 19, 2017

Member

CI run good landing.

Member

mhdawson commented May 19, 2017

CI run good landing.

mhdawson added a commit that referenced this pull request May 19, 2017

doc: update doc to remove usage of "you"
As per style guide avoid the use of you, your etc.
Rational as per: http://www2.ivcc.edu/rambo/tip_formal_writing_voice.htm

PR-URL: #13067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson May 19, 2017

Member

landed as ab34f9d

Member

mhdawson commented May 19, 2017

landed as ab34f9d

@mhdawson mhdawson closed this May 19, 2017

anchnk added a commit to anchnk/node that referenced this pull request May 19, 2017

doc: update doc to remove usage of "you"
As per style guide avoid the use of you, your etc.
Rational as per: http://www2.ivcc.edu/rambo/tip_formal_writing_voice.htm

PR-URL: nodejs#13067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

@mhdawson mhdawson deleted the mhdawson:you-1 branch Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment