Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused parameter #13085

Merged
merged 2 commits into from May 22, 2017

Conversation

@mscdex
Copy link
Contributor

commented May 17, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8140/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • src

@mscdex mscdex force-pushed the mscdex:src-remove-unused-param branch May 18, 2017

@mscdex

This comment has been minimized.

Copy link
Contributor Author

commented May 18, 2017

I've removed some more unused parameters and fixed a code typo (although for some reason it didn't seem to make any difference :-S)

@danbev
danbev approved these changes May 18, 2017

@mscdex mscdex added the semver-major label May 18, 2017

@mscdex

This comment has been minimized.

Copy link
Contributor Author

commented May 18, 2017

I'm marking this as semver-major as it probably should be? If not, feel free to remove the label.

@addaleax

This comment has been minimized.

Copy link
Member

commented May 18, 2017

@mscdex I don’t think you’re touching anything not guarded by NODE_WANT_INTERNALS, right?

@addaleax addaleax removed the semver-major label May 18, 2017

@mscdex

This comment has been minimized.

Copy link
Contributor Author

commented May 18, 2017

@addaleax Ah you're probably right about that. Thanks.

mscdex added 2 commits May 17, 2017
src: remove unused parameters
PR-URL: #13085
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
src: fix typo
PR-URL: #13085
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

@mscdex mscdex force-pushed the mscdex:src-remove-unused-param branch to dcc59f9 May 22, 2017

@mscdex mscdex merged commit dcc59f9 into nodejs:master May 22, 2017

@mscdex mscdex deleted the mscdex:src-remove-unused-param branch May 22, 2017

jasnell added a commit that referenced this pull request May 23, 2017
src: remove unused parameters
PR-URL: #13085
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell added a commit that referenced this pull request May 23, 2017
src: fix typo
PR-URL: #13085
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell added a commit that referenced this pull request May 23, 2017
src: remove unused parameters
PR-URL: #13085
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell added a commit that referenced this pull request May 23, 2017
src: fix typo
PR-URL: #13085
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

Should this be backported to v6.x?

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Aug 14, 2017

ping @mscdex

@mscdex

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2017

I don't know, but I won't have time to backport anytime soon.

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Sep 19, 2017

setting as don't land we can revisit later if we find there are issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.