Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: port disabled readline test #13091

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented May 18, 2017

Port the disabled readline test to make it runnable in our usual test
suite.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test readline

test: port disabled readline test
Port the disabled readline test to make it runnable in our usual test
suite.
@cjihrig
Copy link
Contributor

left a comment

LGTM if the CI passes

@Trott

This comment has been minimized.

Copy link
Member Author

commented May 20, 2017

Trott added a commit to Trott/io.js that referenced this pull request May 21, 2017
test: port disabled readline test
Port the disabled readline test to make it runnable in our usual test
suite.

PR-URL: nodejs#13091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 21, 2017

Landed in 595e5e3

@Trott Trott closed this May 21, 2017

@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.