New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async_wrap: add `asyncReset` to `TLSWrap` #13092

Merged
merged 0 commits into from May 20, 2017

Conversation

Projects
None yet
9 participants
@refack
Member

refack commented May 18, 2017

When using an Agent for HTTPS, TLSSockets are reused and need to
have the ability to asyncReset from JS.

Fixes: #13045
(Not a complete solution. Does not solve custom Agent use case)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

async_wrap

@refack refack added the async_wrap label May 18, 2017

@refack refack self-assigned this May 18, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack May 18, 2017

Member

CI: https://ci.nodejs.org/job/node-test-commit/9967/
(just cause my computer takes so long to build...)

Member

refack commented May 18, 2017

CI: https://ci.nodejs.org/job/node-test-commit/9967/
(just cause my computer takes so long to build...)

@mscdex mscdex added the in progress label May 18, 2017

@refack refack changed the title from [WIP] test-balloon: investigate #13045 to async_wrap: add `asyncReset` to `TLSWrap` May 18, 2017

@refack refack removed the in progress label May 18, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
Member

refack commented May 18, 2017

@refack refack requested a review from trevnorris May 18, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
Member

refack commented May 18, 2017

@refack refack referenced this pull request May 18, 2017

Merged

http: improve outgoing string write performance #13013

2 of 2 tasks complete

@refack refack requested a review from AndreasMadsen May 18, 2017

Show outdated Hide outdated test/parallel/test-async-wrap-GH13045.js Outdated
@refack

This comment has been minimized.

Show comment
Hide comment
Member

refack commented May 18, 2017

@AndreasMadsen

LGTM

@cjihrig

A couple of nits with the test, but mostly LGTM

Show outdated Hide outdated test/parallel/test-async-wrap-GH13045.js Outdated
Show outdated Hide outdated test/parallel/test-async-wrap-GH13045.js Outdated
Show outdated Hide outdated test/parallel/test-async-wrap-GH13045.js Outdated
Show outdated Hide outdated test/parallel/test-async-wrap-GH13045.js Outdated
Show outdated Hide outdated test/parallel/test-async-wrap-GH13045.js Outdated
@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 May 18, 2017

Member

Sounds correct to me.

Member

Fishrock123 commented May 18, 2017

Sounds correct to me.

@refack refack referenced this pull request May 18, 2017

Closed

stream: add destroy and _destroy methods. #12925

4 of 4 tasks complete
@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina May 18, 2017

Member

Can we get a CITGM run? that has been the main blocker for me.

Member

mcollina commented May 18, 2017

Can we get a CITGM run? that has been the main blocker for me.

@addaleax

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated test/parallel/test-async-wrap-GH13045.js Outdated
Show outdated Hide outdated test/parallel/test-async-wrap-GH13045.js Outdated
Show outdated Hide outdated test/parallel/test-async-wrap-GH13045.js Outdated
Show outdated Hide outdated test/parallel/test-async-wrap-GH13045.js Outdated
Show outdated Hide outdated test/parallel/test-async-wrap-GH13045.js Outdated
Show outdated Hide outdated test/parallel/test-async-wrap-GH13045.js Outdated
Show outdated Hide outdated test/parallel/test-async-wrap-GH13045.js Outdated
@mcollina

LGTM

@refack

This comment has been minimized.

Show comment
Hide comment
Member

refack commented May 19, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack May 19, 2017

Member

Pre land CI:https://ci.nodejs.org/job/node-test-commit/10006/

Ping @trevnorris any comments? I would like to land this in a few hours.

Member

refack commented May 19, 2017

Pre land CI:https://ci.nodejs.org/job/node-test-commit/10006/

Ping @trevnorris any comments? I would like to land this in a few hours.

@refack refack closed this May 20, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack May 20, 2017

Member

Landed in 6bfdeed

Member

refack commented May 20, 2017

Landed in 6bfdeed

@refack refack merged commit 6bfdeed into nodejs:master May 20, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack
Member

refack commented May 20, 2017

@refack refack deleted the refack:async-wrap-13045 branch May 20, 2017

@AndreasMadsen

This comment has been minimized.

Show comment
Hide comment
@AndreasMadsen

AndreasMadsen May 20, 2017

Member

@refack Thanks for taking care of this.

Member

AndreasMadsen commented May 20, 2017

@refack Thanks for taking care of this.

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina May 20, 2017

Member

Thank you @refack. 🎉

Member

mcollina commented May 20, 2017

Thank you @refack. 🎉

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Jul 17, 2017

Member

This should likely be included in a larger async_wrap backport if it were to happen

Member

MylesBorins commented Jul 17, 2017

This should likely be included in a larger async_wrap backport if it were to happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment