Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unnecessary return statement #13094

Closed
wants to merge 1 commit into from

Conversation

@danbev
Copy link
Member

commented May 18, 2017

I think the code would be a little clearer if the return statement
was removed here since End() does not return any value and neither
does ParseHeader.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src, crypto

src: remove unnecessary return statement
I think the code would be a little clearer if the return statement
was removed here since End() does not return any value and neither
does ParseHeader.
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 18, 2017

@bnoordhuis
Copy link
Member

left a comment

Virtual shrug. Seems clear enough to me but LGTM if you think this is better.

@thefourtheye
Copy link
Contributor

left a comment

Same as @bnoordhuis's comment.

@danbev

This comment has been minimized.

Copy link
Member Author

commented May 18, 2017

@bnoordhuis @thefourtheye I'll leave this open today and if others feel the same way as you both do (or there are no more comments/approvals) I'll close this and leave it as is.

@refack
refack approved these changes May 18, 2017
danbev added a commit to danbev/node that referenced this pull request May 22, 2017
src: remove unnecessary return statement
I think the code would be a little clearer if the return statement
was removed here since End() does not return any value and neither
does ParseHeader.

PR-URL: nodejs#13094
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 22, 2017

Landed in 762b035

@danbev danbev closed this May 22, 2017

@danbev danbev deleted the danbev:client_hello-remove-return-end branch May 22, 2017

jasnell added a commit that referenced this pull request May 23, 2017
src: remove unnecessary return statement
I think the code would be a little clearer if the return statement
was removed here since End() does not return any value and neither
does ParseHeader.

PR-URL: #13094
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
jasnell added a commit that referenced this pull request May 23, 2017
src: remove unnecessary return statement
I think the code would be a little clearer if the return statement
was removed here since End() does not return any value and neither
does ParseHeader.

PR-URL: #13094
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.