Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused node_buffer.h include #13095

Closed

Conversation

@danbev
Copy link
Member

commented May 18, 2017

I can't find any usage of Buffer in this file and think the include can be
removed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src, crypto

src: remove unused node_buffer.h include
I can't find any usage of Buffer in this file and think the include
can be removed.
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 18, 2017

danbev added a commit to danbev/node that referenced this pull request May 22, 2017
src: remove unused node_buffer.h include
I can't find any usage of Buffer in this file and think the include
can be removed.

PR-URL: nodejs#13095
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 22, 2017

Landed in 7a15eef

@danbev danbev closed this May 22, 2017

@danbev danbev deleted the danbev:crypto_clienthello-remove-buffer-include branch May 22, 2017

jasnell added a commit that referenced this pull request May 23, 2017
src: remove unused node_buffer.h include
I can't find any usage of Buffer in this file and think the include
can be removed.

PR-URL: #13095
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell added a commit that referenced this pull request May 23, 2017
src: remove unused node_buffer.h include
I can't find any usage of Buffer in this file and think the include
can be removed.

PR-URL: #13095
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
MylesBorins added a commit that referenced this pull request Jul 17, 2017
src: remove unused node_buffer.h include
I can't find any usage of Buffer in this file and think the include
can be removed.

PR-URL: #13095
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.