Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test,dgram: harden test-dgram-bind-shared-ports.js #13100

Merged
merged 0 commits into from Jun 9, 2017

Conversation

@refack
Copy link
Member

commented May 18, 2017

  • add mustCall and mustNotCall to all callbacks
  • exit the processes instead of kill

Ref: #13055
Ref: #12999
Ref: #13526

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

dgram,cluster,test

@refack

This comment has been minimized.

@gibfahn

This comment has been minimized.

Copy link
Member

commented May 18, 2017

FWIW you can run node-test-commit or node-stress-single-test on a branch of your fork of Node if you want.

@refack

This comment has been minimized.

Copy link
Member Author

commented May 18, 2017

FWIW you can run node-test-commit or node-stress-single-test on a branch of your fork of Node if you want.

Thanks, I was vaguely aware of that, but was not sure...
Anyway this might mature into a real PR (maybe).

test/parallel/test-dgram-bind-shared-ports.js Outdated
// an error is expected on the second worker
process.send(`socket2:${err.code}`);
});
socket2.close(common.mustCall(() => {

This comment has been minimized.

Copy link
@Trott

Trott May 18, 2017

Member

FWIW, I think this will only fire in the second worker. The first worker doesn't get an error on socket2 (and it's the first worker we care about for socket2 because it actually binds to the port).

Starting to wonder if whatever complexity is required to make socket2.close() work isn't any greater than complexity that might be required to make port: 0 work for this test. :-|

@refack

This comment has been minimized.

Copy link
Member Author

commented May 18, 2017

ork for this test. :-|

Is that a wink?

@refack refack force-pushed the refack:13064 branch 3 times, most recently May 18, 2017
@refack refack changed the title [WIP] test balloon for 13064 test,dgram: harden test-dgram-bind-shared-ports.js May 18, 2017
@refack

This comment has been minimized.

Copy link
Member Author

commented May 18, 2017

@refack

This comment has been minimized.

Copy link
Member Author

commented May 19, 2017

Found a bug when workers bind for port 0. Blocking until I fix it.

@refack refack added the blocked label May 19, 2017
@refack refack referenced this pull request May 20, 2017
3 of 3 tasks complete
@fhinkel

This comment has been minimized.

Copy link
Member

commented Jun 7, 2017

ping @refack can this be landed now that #13064 is closed?

@refack refack changed the title test,dgram: harden test-dgram-bind-shared-ports.js cluster: enable `cluster` to share sockets when worker bind to port 0 Jun 7, 2017
@refack refack closed this Jun 9, 2017
@refack refack force-pushed the refack:13064 branch to c9d45c4 Jun 9, 2017
@refack

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2017

Landed in c9d45c4

@refack refack merged commit c9d45c4 into nodejs:master Jun 9, 2017
@refack

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2017

@refack refack deleted the refack:13064 branch Jun 9, 2017
addaleax added a commit that referenced this pull request Jun 10, 2017
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

PR-URL: #13100
Refs: #13055
Refs: #12999
Refs: #13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@addaleax addaleax referenced this pull request Jun 10, 2017
@refack refack removed their assignment Jun 12, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

@refack could you please backport to v6.x?

refack added a commit to refack/node that referenced this pull request Jul 17, 2017
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

PR-URL: nodejs#13100
Refs: nodejs#13055
Refs: nodejs#12999
Refs: nodejs#13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@refack refack referenced this pull request Jul 17, 2017
2 of 3 tasks complete
@refack

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2017

@refack could you please backport to v6.x?

#14327

MylesBorins added a commit that referenced this pull request Aug 14, 2017
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

PR-URL: #13100
Refs: #13055
Refs: #12999
Refs: #13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins added a commit that referenced this pull request Aug 14, 2017
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

Backport-PR-URL: #14327
PR-URL: #13100
Refs: #13055
Refs: #12999
Refs: #13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins added a commit that referenced this pull request Aug 14, 2017
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

Backport-PR-URL: #14327
PR-URL: #13100
Refs: #13055
Refs: #12999
Refs: #13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins added a commit that referenced this pull request Aug 16, 2017
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

Backport-PR-URL: #14327
PR-URL: #13100
Refs: #13055
Refs: #12999
Refs: #13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins MylesBorins referenced this pull request Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.