Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: allow for absent nobody user in setuid test #13112

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented May 19, 2017

Some isolated build or test VMs don't have a "nobody" user, causing the
parallel/test-process-setuid-setgid test to fail. Add logic to allow for
that situation.

Fixes: #13071

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test process

test: allow for absent nobody user in setuid test
Some isolated build or test VMs don't have a "nobody" user, causing the
parallel/test-process-setuid-setgid test to fail. Add logic to allow for
that situation.

Fixes: #13071
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 19, 2017

This only fixes it for when the test is not run as super user, but the other pre-existing special logic for non-existent nobody GID also only applies to non-super user runs.

Dealing with missing nobody user when run as super-user can be a separate PR, or no PR at all as we probably don't want to encourage people to run the tests as super user.

Either way, this PR is still an improvement.

@Trott

This comment has been minimized.

Copy link
Member Author

commented May 19, 2017

@Qantas94Heavy Can you confirm that this change makes the test pass in your environment?

@Qantas94Heavy

This comment has been minimized.

Copy link
Member

commented May 19, 2017

@Trott yes, this patch fixes the issue. 👍

@Trott

This comment has been minimized.

Copy link
Member Author

commented May 19, 2017

@lpinca
lpinca approved these changes May 20, 2017
Trott added a commit to Trott/io.js that referenced this pull request May 22, 2017
test: allow for absent nobody user in setuid test
Some isolated build or test VMs don't have a "nobody" user, causing the
parallel/test-process-setuid-setgid test to fail. Add logic to allow for
that situation.

PR-URL: nodejs#13112
Fixes: nodejs#13071
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 22, 2017

Landed in 8e47600

@Trott Trott closed this May 22, 2017

jasnell added a commit that referenced this pull request May 23, 2017
test: allow for absent nobody user in setuid test
Some isolated build or test VMs don't have a "nobody" user, causing the
parallel/test-process-setuid-setgid test to fail. Add logic to allow for
that situation.

PR-URL: #13112
Fixes: #13071
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell added a commit that referenced this pull request May 23, 2017
test: allow for absent nobody user in setuid test
Some isolated build or test VMs don't have a "nobody" user, causing the
parallel/test-process-setuid-setgid test to fail. Add logic to allow for
that situation.

PR-URL: #13112
Fixes: #13071
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
MylesBorins added a commit that referenced this pull request Jul 17, 2017
test: allow for absent nobody user in setuid test
Some isolated build or test VMs don't have a "nobody" user, causing the
parallel/test-process-setuid-setgid test to fail. Add logic to allow for
that situation.

PR-URL: #13112
Fixes: #13071
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.