New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: link to `common` docs in test writing guide #13118

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
10 participants
@addaleax
Member

addaleax commented May 19, 2017

Checklist
Affected core subsystem(s)

doc/guides

@mhdawson

LGTM

@refack

refack approved these changes May 19, 2017

Was just about to do that 😄

@mscdex mscdex added the test label May 19, 2017

@Trott

Trott approved these changes May 20, 2017

LGTM

@lpinca

lpinca approved these changes May 20, 2017

@mhdawson

This comment has been minimized.

Show comment
Hide comment
Member

mhdawson commented May 23, 2017

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax May 23, 2017

Member

Landed in 02bf16e

Member

addaleax commented May 23, 2017

Landed in 02bf16e

@addaleax addaleax closed this May 23, 2017

@addaleax addaleax deleted the addaleax:doc-link-to-common-docs branch May 23, 2017

addaleax added a commit that referenced this pull request May 23, 2017

doc: link to `common` docs in test writing guide
PR-URL: #13118
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell added a commit that referenced this pull request May 24, 2017

doc: link to `common` docs in test writing guide
PR-URL: #13118
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell added a commit that referenced this pull request May 28, 2017

doc: link to `common` docs in test writing guide
PR-URL: #13118
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment