Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: redirect-warnings to file, not path #13120

Closed

Conversation

@sam-github
Copy link
Member

commented May 19, 2017

Use file as name of the argument, as the CLI documentation does.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

src,doc?

src: redirect-warnings to file, not path
Use `file` as name of the argument, as the CLI documentation does.
@sam-github

This comment has been minimized.

@sam-github

This comment has been minimized.

Copy link
Member Author

commented May 19, 2017

@mscdex mscdex added the cli label May 19, 2017

@refack
refack approved these changes May 19, 2017
Copy link
Member

left a comment

Makes more sense

@lpinca
lpinca approved these changes May 20, 2017
@addaleax

This comment has been minimized.

Copy link
Member

commented May 23, 2017

Landed in a886b17

@addaleax addaleax closed this May 23, 2017

addaleax added a commit that referenced this pull request May 23, 2017
src: redirect-warnings to file, not path
Use `file` as name of the argument, as the CLI documentation does.

PR-URL: #13120
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@sam-github sam-github deleted the sam-github:clarify-redirect-warnings-usage branch May 23, 2017

jasnell added a commit that referenced this pull request May 24, 2017
src: redirect-warnings to file, not path
Use `file` as name of the argument, as the CLI documentation does.

PR-URL: #13120
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request May 28, 2017
src: redirect-warnings to file, not path
Use `file` as name of the argument, as the CLI documentation does.

PR-URL: #13120
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

@sam-github

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2017

Depends on #10116 which has not yet been backported to 6.x. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.