Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase n-api constructor coverage #13124

Closed
wants to merge 2 commits into from

Conversation

@mhdawson
Copy link
Member

commented May 19, 2017

Add tests to validate that properties marked as static
are available through the class as opposed to instances

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows [commit guidelines]
Affected core subsystem(s)

test, n-api

test: increase n-api constructor coverage
Add tests to validate that properties marked as static
are available through the class as opposed to instances
@mhdawson

This comment has been minimized.

Copy link
Member Author

commented May 23, 2017

@addaleax

This comment has been minimized.

Copy link
Member

commented May 23, 2017

Landed in 47919b3

@addaleax addaleax closed this May 23, 2017

addaleax added a commit that referenced this pull request May 23, 2017
test: increase n-api constructor coverage
Add tests to validate that properties marked as static
are available through the class as opposed to instances

PR-URL: #13124
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
jasnell added a commit that referenced this pull request May 24, 2017
test: increase n-api constructor coverage
Add tests to validate that properties marked as static
are available through the class as opposed to instances

PR-URL: #13124
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
jasnell added a commit that referenced this pull request May 28, 2017
test: increase n-api constructor coverage
Add tests to validate that properties marked as static
are available through the class as opposed to instances

PR-URL: #13124
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017

@mhdawson mhdawson deleted the mhdawson:napi-cov6 branch Jun 28, 2017

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 12, 2018
test: increase n-api constructor coverage
Add tests to validate that properties marked as static
are available through the class as opposed to instances

PR-URL: nodejs#13124
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 31, 2018
test: increase n-api constructor coverage
Add tests to validate that properties marked as static
are available through the class as opposed to instances

PR-URL: nodejs#13124
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
test: increase n-api constructor coverage
Add tests to validate that properties marked as static
are available through the class as opposed to instances

PR-URL: nodejs#13124
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
MylesBorins added a commit that referenced this pull request Apr 16, 2018
test: increase n-api constructor coverage
Add tests to validate that properties marked as static
are available through the class as opposed to instances

Backport-PR-URL: #19447
PR-URL: #13124
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
@MylesBorins MylesBorins referenced this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.