New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve formatting of STYLE_GUIDE.md #13135

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
@aqrln
Member

aqrln commented May 20, 2017

  • Wrap text at 80 characters.
  • Use periods consistently.
Checklist
Affected core subsystem(s)

doc

doc: improve formatting of STYLE_GUIDE.md
* Wrap text at 80 characters.
* Use periods consistently.
@refack

refack approved these changes May 21, 2017

@Trott

Trott approved these changes May 21, 2017 edited

This is great. LGTM. Thanks for doing this. I left a bunch of nits, but I'm fine with this landing even if none of them get addressed. This PR is a clear improvement as-is over the current doc. Thanks again!

Show outdated Hide outdated doc/STYLE_GUIDE.md
Show outdated Hide outdated doc/STYLE_GUIDE.md
Show outdated Hide outdated doc/STYLE_GUIDE.md
Show outdated Hide outdated doc/STYLE_GUIDE.md
@lpinca

lpinca approved these changes May 21, 2017

@cjihrig

LGTM with @Trott's nits addressed.

@mhdawson

LGTM

@mhdawson

This comment has been minimized.

Show comment
Hide comment
Member

mhdawson commented May 23, 2017

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax May 23, 2017

Member

LGTM

Landed in eebc262

Member

addaleax commented May 23, 2017

LGTM

Landed in eebc262

@addaleax addaleax closed this May 23, 2017

addaleax added a commit that referenced this pull request May 23, 2017

doc: improve formatting of STYLE_GUIDE.md
* Wrap text at 80 characters.
* Use periods consistently.

PR-URL: #13135
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

@aqrln aqrln deleted the aqrln:improve-style-guide branch May 24, 2017

jasnell added a commit that referenced this pull request May 24, 2017

doc: improve formatting of STYLE_GUIDE.md
* Wrap text at 80 characters.
* Use periods consistently.

PR-URL: #13135
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

jasnell added a commit that referenced this pull request May 28, 2017

doc: improve formatting of STYLE_GUIDE.md
* Wrap text at 80 characters.
* Use periods consistently.

PR-URL: #13135
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

MylesBorins added a commit that referenced this pull request Jul 17, 2017

doc: improve formatting of STYLE_GUIDE.md
* Wrap text at 80 characters.
* Use periods consistently.

PR-URL: #13135
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jul 18, 2017

Merged

v6.11.2 proposal #14356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment