New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update code example for Windows in stream.md #13138

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@vsemozhetbyt
Member

vsemozhetbyt commented May 21, 2017

Checklist
Affected core subsystem(s)

doc, stream

Commands with single quotes fail in cmd.exe shell (while being OK in Git Bash for Windows):

> curl localhost:1337 -d '{}'
error: Unexpected token ' in JSON at position 0
> curl localhost:1337 -d '"foo"'
error: Unexpected token ' in JSON at position 0
> curl localhost:1337 -d 'not json'
error: Unexpected token ' in JSON at position 0curl: (6) Couldn't resolve host 'json''

Commands with double quotes are OK in both cmd.exe shell and Git Bash for Windows.

@lpinca

lpinca approved these changes May 22, 2017

@mcollina

LGTM

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt May 24, 2017

Member

Landed in 9278ce2

Member

vsemozhetbyt commented May 24, 2017

Landed in 9278ce2

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:stream-curl-win branch May 24, 2017

vsemozhetbyt added a commit that referenced this pull request May 24, 2017

doc: update code example for Windows in stream.md
PR-URL: #13138
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell added a commit that referenced this pull request May 24, 2017

doc: update code example for Windows in stream.md
PR-URL: #13138
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell added a commit that referenced this pull request May 28, 2017

doc: update code example for Windows in stream.md
PR-URL: #13138
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

MylesBorins added a commit that referenced this pull request Jul 17, 2017

doc: update code example for Windows in stream.md
PR-URL: #13138
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jul 18, 2017

Merged

v6.11.2 proposal #14356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment