New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: don't use useless constructors in stream.md #13145

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@vsemozhetbyt
Member

vsemozhetbyt commented May 21, 2017

Checklist
Affected core subsystem(s)

doc, stream

Refs: http://eslint.org/docs/rules/no-useless-constructor

ES2015 provides a default class constructor if one is not specified. As such, it is unnecessary to provide an empty constructor or one that simply delegates into its parent class...

The constructors in these fragments could be completely removed to eliminate useless constructor promotion, but this would make the examples a bit bare, so I've decided to just add ellipses to hint at an extension of code.

@refack

refack approved these changes May 21, 2017

Sounds like a good idea

@mcollina

LGTM

@danbev

danbev approved these changes May 22, 2017

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt May 24, 2017

Member

Landed in 6af72d4

Member

vsemozhetbyt commented May 24, 2017

Landed in 6af72d4

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:stream-no-useless-constructor branch May 24, 2017

vsemozhetbyt added a commit that referenced this pull request May 24, 2017

doc: don't use useless constructors in stream.md
PR-URL: #13145
Refs: http://eslint.org/docs/rules/no-useless-constructor
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell added a commit that referenced this pull request May 24, 2017

doc: don't use useless constructors in stream.md
PR-URL: #13145
Refs: http://eslint.org/docs/rules/no-useless-constructor
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell added a commit that referenced this pull request May 28, 2017

doc: don't use useless constructors in stream.md
PR-URL: #13145
Refs: http://eslint.org/docs/rules/no-useless-constructor
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

MylesBorins added a commit that referenced this pull request Jul 17, 2017

doc: don't use useless constructors in stream.md
PR-URL: #13145
Refs: http://eslint.org/docs/rules/no-useless-constructor
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jul 18, 2017

Merged

v6.11.2 proposal #14356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment