Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix disabled test-fs-largefile #13147

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented May 22, 2017

Add common.refreshTmpDir() before using the tmp directory.

fs.writeSync no longer requires an integer for the position argument, so
change test from assert.throws() to assert.doesNotThrow(). The test
now passes.

Because it involves a 5 GB file, we're not going to activate the test,
although that is possible if we add checking for appropriate available
resources (definitely disk space, likely memory, maybe check that it's a
64-bit OS).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test fs

test: fix disabled test-fs-largefile
Add `common.refreshTmpDir()` before using the tmp directory.

fs.writeSync no longer requires an integer for the position argument, so
change test from `assert.throws()` to `assert.doesNotThrow()`. The test
now passes.

Because it involves a 5 GB file, we're not going to activate the test,
although that is possible if we add checking for appropriate available
resources (definitely disk space, likely memory, maybe check that it's a
64-bit OS).

@Trott Trott added fs test labels May 22, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented May 22, 2017

Also, consider file system restrictions (FAT32 cannot have a 5 GB file etc).

@Trott

This comment has been minimized.

Copy link
Member Author

commented May 24, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented May 24, 2017

Sole CI failure is an unrelated build issue.

Trott added a commit to Trott/io.js that referenced this pull request May 24, 2017
test: fix disabled test-fs-largefile
Add `common.refreshTmpDir()` before using the tmp directory.

fs.writeSync no longer requires an integer for the position argument, so
change test from `assert.throws()` to `assert.doesNotThrow()`. The test
now passes.

Because it involves a 5 GB file, we're not going to activate the test,
although that is possible if we add checking for appropriate available
resources (definitely disk space, likely memory, maybe check that it's a
64-bit OS).

PR-URL: nodejs#13147
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 24, 2017

Landed in bbf74fb

@Trott Trott closed this May 24, 2017

jasnell added a commit that referenced this pull request May 25, 2017
test: fix disabled test-fs-largefile
Add `common.refreshTmpDir()` before using the tmp directory.

fs.writeSync no longer requires an integer for the position argument, so
change test from `assert.throws()` to `assert.doesNotThrow()`. The test
now passes.

Because it involves a 5 GB file, we're not going to activate the test,
although that is possible if we add checking for appropriate available
resources (definitely disk space, likely memory, maybe check that it's a
64-bit OS).

PR-URL: #13147
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell added a commit that referenced this pull request May 28, 2017
test: fix disabled test-fs-largefile
Add `common.refreshTmpDir()` before using the tmp directory.

fs.writeSync no longer requires an integer for the position argument, so
change test from `assert.throws()` to `assert.doesNotThrow()`. The test
now passes.

Because it involves a 5 GB file, we're not going to activate the test,
although that is possible if we add checking for appropriate available
resources (definitely disk space, likely memory, maybe check that it's a
64-bit OS).

PR-URL: #13147
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

should this land on v6.x?

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2017

should this land on v6.x?

@MylesBorins I would say "no" and have added dont-land labels for 6.x and 4.x.

@gibfahn

This comment has been minimized.

Copy link
Member

commented Jul 18, 2017

@Trott maybe we could add this test to pummel?

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2017

@gibfahn Good suggestion. #14338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.