Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cover util.format() format placeholders #13159

Closed
wants to merge 1 commit into from

Conversation

@cjihrig
Copy link
Contributor

commented May 22, 2017

This commit adds coverage for several edge cases related to util.format() format string placeholders.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: cover util.format() format placeholders
This commit adds coverage for several edge cases related to
util.format() format string placeholders.

@mscdex mscdex added the util label May 22, 2017

@refack
refack approved these changes May 22, 2017
@lpinca
lpinca approved these changes May 23, 2017
@addaleax

This comment has been minimized.

Copy link
Member

commented May 25, 2017

Landed in 0903dcf

@addaleax addaleax closed this May 25, 2017

@cjihrig cjihrig deleted the cjihrig:util branch May 25, 2017

addaleax added a commit that referenced this pull request May 25, 2017
test: cover util.format() format placeholders
This commit adds coverage for several edge cases related to
util.format() format string placeholders.

PR-URL: #13159
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request May 25, 2017
test: cover util.format() format placeholders
This commit adds coverage for several edge cases related to
util.format() format string placeholders.

PR-URL: #13159
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this pull request May 28, 2017
test: cover util.format() format placeholders
This commit adds coverage for several edge cases related to
util.format() format string placeholders.

PR-URL: #13159
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.