Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-dns #13163

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented May 23, 2017

  • track callback invocations with common.mustCall() and
    common.mustNotCall()
  • remove test in test/internet/test-dns.js that is duplicated in
    test/parallel/test-dns.js
  • move tests that might perform a DNS query from test
    test/parallel/test-dns.js to test/internet/test-dns.js
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test dns

@Trott Trott added dns test labels May 23, 2017

test/internet/test-dns.js Outdated
@@ -578,3 +565,12 @@ process.on('exit', function() {
assert.strictEqual(expected, completed);
assert.ok(getaddrinfoCallbackCalled);
});


assert.doesNotThrow(() => dns.lookup('www.google.com', 6, common.mustCall()));

This comment has been minimized.

Copy link
@jasnell

jasnell May 23, 2017

Member

would prefer if these used a more generic domain like example.org

@refack
refack approved these changes May 23, 2017
@lpinca
lpinca approved these changes May 23, 2017
test: refactor test-dns
* track callback invocations with common.mustCall() and
  common.mustNotCall()
* remove test in test/internet/test-dns.js that is duplicated in
  test/parallel/test-dns.js
* move tests that might perform a DNS query from test
  test/parallel/test-dns.js to test/internet/test-dns.js

@Trott Trott force-pushed the Trott:dnstest branch to 33f51e2 May 24, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented May 24, 2017

Trott added a commit to Trott/io.js that referenced this pull request May 25, 2017
test: refactor test-dns
* track callback invocations with common.mustCall() and
  common.mustNotCall()
* remove test in test/internet/test-dns.js that is duplicated in
  test/parallel/test-dns.js
* move tests that might perform a DNS query from test
  test/parallel/test-dns.js to test/internet/test-dns.js

PR-URL: nodejs#13163
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 25, 2017

Landed in 235cbbe

@Trott Trott closed this May 25, 2017

jasnell added a commit that referenced this pull request May 25, 2017
test: refactor test-dns
* track callback invocations with common.mustCall() and
  common.mustNotCall()
* remove test in test/internet/test-dns.js that is duplicated in
  test/parallel/test-dns.js
* move tests that might perform a DNS query from test
  test/parallel/test-dns.js to test/internet/test-dns.js

PR-URL: #13163
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell added a commit that referenced this pull request May 28, 2017
test: refactor test-dns
* track callback invocations with common.mustCall() and
  common.mustNotCall()
* remove test in test/internet/test-dns.js that is duplicated in
  test/parallel/test-dns.js
* move tests that might perform a DNS query from test
  test/parallel/test-dns.js to test/internet/test-dns.js

PR-URL: #13163
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jul 17, 2017

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.