Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: make StreamBase::GetAsyncWrap pure virtual #13174

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented May 23, 2017

Splitting out from #13142, this is a bit that should be easy to review. (All remaining GetAsyncWrap methods never return nullptr.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
@AndreasMadsen
Copy link
Member

left a comment

LGTM

@danbev
danbev approved these changes May 24, 2017
@addaleax addaleax referenced this pull request May 24, 2017
2 of 2 tasks complete
@addaleax

This comment has been minimized.

Copy link
Member Author

commented May 25, 2017

@addaleax

This comment has been minimized.

Copy link
Member Author

commented May 25, 2017

Landed in 169c07d

@addaleax addaleax closed this May 25, 2017

@addaleax addaleax deleted the addaleax:stream-wrap-virtual-gaw branch May 25, 2017

addaleax added a commit that referenced this pull request May 25, 2017
src: make StreamBase::GetAsyncWrap pure virtual
PR-URL: #13174
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell added a commit that referenced this pull request May 25, 2017
src: make StreamBase::GetAsyncWrap pure virtual
PR-URL: #13174
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell added a commit that referenced this pull request May 28, 2017
src: make StreamBase::GetAsyncWrap pure virtual
PR-URL: #13174
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@jasnell jasnell referenced this pull request May 28, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Aug 14, 2017

@addaleax should we land this now or wait for a larger async_hooks update?

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2017

@MylesBorins This is not the kind of change that would be harmful to include, or that would need to bake for any significant time. If it compiles, include it. :)

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Oct 16, 2017

@addaleax it does not land cleanly, I don't think the async_wrap stuff has been backported

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Jan 11, 2018

ping re: backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.