New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cherry-pick 6803eef from V8 upstream #13175

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@matthewloring
Contributor

matthewloring commented May 23, 2017

Original commit message:
Allow embedder to set promise internal field count

Asynchronous context tracking mechanisms in Node.js need to store some
state on all promise objects. This change will allow embedders to
configure the number of internal fields on promises as is already done
for ArrayBuffers.

BUG=v8:6435

Review-Url: https://codereview.chromium.org/2889863002
Cr-Commit-Position: refs/heads/master@{#45496}

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
@matthewloring

This comment has been minimized.

Show comment
Hide comment
@matthewloring

matthewloring May 23, 2017

Contributor

@gsathya It seems like Factory::NewJSPromise did not exist in V8 5.8. Is there anything that should be patched in its place?

Contributor

matthewloring commented May 23, 2017

@gsathya It seems like Factory::NewJSPromise did not exist in V8 5.8. Is there anything that should be patched in its place?

@gsathya

This comment has been minimized.

Show comment
Hide comment
@gsathya

gsathya May 23, 2017

Member

Is there anything that should be patched in its place?

No, don't think so

Member

gsathya commented May 23, 2017

Is there anything that should be patched in its place?

No, don't think so

@mscdex mscdex added the promises label May 23, 2017

@richardlau

This comment has been minimized.

Show comment
Hide comment
@richardlau

richardlau May 24, 2017

Member

Are we bumping the V8 patch level? (#13162 (comment))

Member

richardlau commented May 24, 2017

Are we bumping the V8 patch level? (#13162 (comment))

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax
Member

addaleax commented May 25, 2017

deps: cherry-pick 6803eef from V8 upstream
Original commit message:
Allow embedder to set promise internal field count

Asynchronous context tracking mechanisms in Node.js need to store some
state on all promise objects. This change will allow embedders to
configure the number of internal fields on promises as is already done
for ArrayBuffers.

BUG=v8:6435

Review-Url: https://codereview.chromium.org/2889863002
Cr-Commit-Position: refs/heads/master@{#45496}
@matthewloring

This comment has been minimized.

Show comment
Hide comment
@matthewloring

matthewloring May 25, 2017

Contributor

@richardlau I've bumped the patch level

Contributor

matthewloring commented May 25, 2017

@richardlau I've bumped the patch level

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax May 26, 2017

Member

Landed in e6395cc

Member

addaleax commented May 26, 2017

Landed in e6395cc

@addaleax addaleax closed this May 26, 2017

addaleax added a commit that referenced this pull request May 26, 2017

deps: cherry-pick 6803eef from V8 upstream
Original commit message:
  Allow embedder to set promise internal field count

  Asynchronous context tracking mechanisms in Node.js need to store some
  state on all promise objects. This change will allow embedders to
  configure the number of internal fields on promises as is already done
  for ArrayBuffers.

  BUG=v8:6435

  Review-Url: https://codereview.chromium.org/2889863002
  Cr-Commit-Position: refs/heads/master@{#45496}

PR-URL: #13175
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell added a commit that referenced this pull request May 28, 2017

deps: cherry-pick 6803eef from V8 upstream
Original commit message:
  Allow embedder to set promise internal field count

  Asynchronous context tracking mechanisms in Node.js need to store some
  state on all promise objects. This change will allow embedders to
  configure the number of internal fields on promises as is already done
  for ArrayBuffers.

  BUG=v8:6435

  Review-Url: https://codereview.chromium.org/2889863002
  Cr-Commit-Position: refs/heads/master@{#45496}

PR-URL: #13175
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@matthewloring matthewloring deleted the matthewloring:promise-internal-field branch Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment