New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix code example in inspector.md #13182

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@vsemozhetbyt
Member

vsemozhetbyt commented May 24, 2017

Checklist
Affected core subsystem(s)

doc, inspector

console.log(result.value) outputs just 4.

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
Member

vsemozhetbyt commented May 24, 2017

@refack

refack approved these changes May 24, 2017

Do we lint for space inside object literals? { a }

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt May 24, 2017

Member

@refack No, but this is rather common in the docs.

Member

vsemozhetbyt commented May 24, 2017

@refack No, but this is rather common in the docs.

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack May 24, 2017

Member

@refack No, but this is rather common in the docs.

I personally like it. If it's common we should lint for it.

Member

refack commented May 24, 2017

@refack No, but this is rather common in the docs.

I personally like it. If it's common we should lint for it.

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt May 24, 2017

Member

Well, if there is some unanimity for this, I could address this. But I would not bother everybody with this PR for spaces only, I've just fixed the result.value issue and other nits besides.

Member

vsemozhetbyt commented May 24, 2017

Well, if there is some unanimity for this, I could address this. But I would not bother everybody with this PR for spaces only, I've just fixed the result.value issue and other nits besides.

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt May 26, 2017

Member

Landed in 329b6e9

Member

vsemozhetbyt commented May 26, 2017

Landed in 329b6e9

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:inspector.md branch May 26, 2017

vsemozhetbyt added a commit that referenced this pull request May 26, 2017

doc: fix code example in inspector.md
PR-URL: #13182
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell added a commit that referenced this pull request May 28, 2017

doc: fix code example in inspector.md
PR-URL: #13182
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment